Differential D18966

Upgrade user account activity logs to modern construction
ClosedPublic
Actions

Authored by epriestley on Jan 30 2018, 2:12 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.)

Commits

rP91108cf83826: Upgrade user account activity logs to modern construction

Summary

Depends on D18965. Ref T13049. Move this Query and SearchEngine to be a little more modern, to prepare for Export support.

Test Plan

Used all the query fields, viewed activity logs via People and Settings.
I'm not sure the "Session" query is used/useful and may remove it before I'm done here, but I just left it in place for now.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 30 2018, 2:12 PM

Harbormaster completed remote builds in B19276: Diff 45488.Jan 30 2018, 2:13 PM

epriestley requested review of this revision.Jan 30 2018, 2:13 PM

epriestley added a child revision: D18967: Support export of user activity logs.Jan 30 2018, 3:06 PM

amckinley accepted this revision.Jan 30 2018, 6:41 PM

This revision is now accepted and ready to land.Jan 30 2018, 6:41 PM

Closed by commit rP91108cf83826: Upgrade user account activity logs to modern construction (authored by epriestley). · Explain WhyJan 30 2018, 7:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

query/

PhabricatorPeopleLogQuery.php

39 lines

PhabricatorPeopleLogSearchEngine.php

157 lines

view/

PhabricatorUserLogView.php

15 lines

settings/

panel/

PhabricatorActivitySettingsPanel.php

3 lines

Diff 45493

View Options

src/applications/people/query/PhabricatorPeopleLogQuery.php

View Options

src/applications/people/query/PhabricatorPeopleLogSearchEngine.php

View Options

src/applications/people/view/PhabricatorUserLogView.php

View Options

src/applications/settings/panel/PhabricatorActivitySettingsPanel.php

Upgrade user account activity logs to modern constructionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45493

src/applications/people/query/PhabricatorPeopleLogQuery.php

src/applications/people/query/PhabricatorPeopleLogSearchEngine.php

src/applications/people/view/PhabricatorUserLogView.php

src/applications/settings/panel/PhabricatorActivitySettingsPanel.php

Upgrade user account activity logs to modern construction
ClosedPublic
Actions

Revision Contents
Changeset List