Differential D18956

Organize the export code into subdirectories
ClosedPublic
Actions

Authored by epriestley on Jan 29 2018, 3:26 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.)

Commits

rP5b61f863fdc1: Organize the export code into subdirectories

Summary

Depends on D18955. Ref T13049. This directory was getting a little cluttered with different kinds of code.

Put the formats (csv, json, ...), the field types (int, string, epoch, ...) and the engine-related stuff in subdirectories.

Test Plan

wow so aesthetic

Diff Detail

Repository

rP Phabricator

Branch

export6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19239
Build 25994: Run Core Tests
Build 25993: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 29 2018, 3:26 PM

Harbormaster completed remote builds in B19239: Diff 45455.Jan 29 2018, 3:27 PM

epriestley requested review of this revision.Jan 29 2018, 3:27 PM

epriestley added a child revision: D18957: Make the data export format selector remember your last setting.Jan 29 2018, 3:35 PM

One field and one format got swapped.

Harbormaster completed remote builds in B19242: Diff 45458.Jan 29 2018, 4:14 PM

amckinley accepted this revision.Jan 29 2018, 9:31 PM

This revision is now accepted and ready to land.Jan 29 2018, 9:31 PM

Closed by commit rP5b61f863fdc1: Organize the export code into subdirectories (authored by epriestley). · Explain WhyJan 30 2018, 12:01 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

26 lines

infrastructure/

export/

PhabricatorCSVExportFormat.php

PhabricatorCustomFieldExportEngineExtension.php

PhabricatorEpochExportField.php

PhabricatorExcelExportFormat.php

PhabricatorExportEngineExtension.php

PhabricatorExportField.php

PhabricatorExportFormat.php

PhabricatorIDExportField.php

PhabricatorIntExportField.php

PhabricatorJSONExportFormat.php

PhabricatorPHIDExportField.php

PhabricatorStringExportField.php

PhabricatorTextExportFormat.php

	engine/

PhabricatorCustomFieldExportEngineExtension.php

86 lines

PhabricatorExportEngineExtension.php

31 lines

	field/

PhabricatorEpochExportField.php

47 lines

PhabricatorExportField.php

50 lines

PhabricatorExportFormat.php

65 lines

PhabricatorIDExportField.php

14 lines

PhabricatorIntExportField.php

25 lines

PhabricatorPHIDExportField.php

10 lines

	format/

PhabricatorCSVExportFormat.php

60 lines

PhabricatorExcelExportFormat.php

145 lines

PhabricatorJSONExportFormat.php

43 lines

PhabricatorStringExportField.php

4 lines

PhabricatorTextExportFormat.php

55 lines

Diff 45455

View Options

src/__phutil_library_map__.php

View Options

src/infrastructure/export/PhabricatorCSVExportFormat.php

View Options

src/infrastructure/export/PhabricatorCustomFieldExportEngineExtension.php

View Options

src/infrastructure/export/PhabricatorEpochExportField.php

View Options

src/infrastructure/export/PhabricatorExcelExportFormat.php

View Options

src/infrastructure/export/PhabricatorExportEngineExtension.php

View Options

src/infrastructure/export/PhabricatorExportField.php

View Options

src/infrastructure/export/PhabricatorExportFormat.php

View Options

src/infrastructure/export/PhabricatorIDExportField.php

View Options

src/infrastructure/export/PhabricatorIntExportField.php

View Options

src/infrastructure/export/PhabricatorJSONExportFormat.php

View Options

src/infrastructure/export/PhabricatorPHIDExportField.php

View Options

src/infrastructure/export/PhabricatorStringExportField.php

View Options

src/infrastructure/export/PhabricatorTextExportFormat.php

View Options

src/infrastructure/export/engine/PhabricatorCustomFieldExportEngineExtension.php

View Options

src/infrastructure/export/engine/PhabricatorExportEngineExtension.php

View Options

src/infrastructure/export/field/PhabricatorEpochExportField.php

View Options

src/infrastructure/export/field/PhabricatorExportField.php

View Options

src/infrastructure/export/field/PhabricatorExportFormat.php

View Options

src/infrastructure/export/field/PhabricatorIDExportField.php

View Options

src/infrastructure/export/field/PhabricatorIntExportField.php

View Options

src/infrastructure/export/field/PhabricatorPHIDExportField.php

View Options

src/infrastructure/export/format/PhabricatorCSVExportFormat.php

View Options

src/infrastructure/export/format/PhabricatorExcelExportFormat.php

View Options

src/infrastructure/export/format/PhabricatorJSONExportFormat.php

View Options

src/infrastructure/export/format/PhabricatorStringExportField.php

View Options

src/infrastructure/export/format/PhabricatorTextExportFormat.php

Organize the export code into subdirectoriesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45455

src/__phutil_library_map__.php

src/infrastructure/export/PhabricatorCSVExportFormat.php

src/infrastructure/export/PhabricatorCustomFieldExportEngineExtension.php

src/infrastructure/export/PhabricatorEpochExportField.php

src/infrastructure/export/PhabricatorExcelExportFormat.php

src/infrastructure/export/PhabricatorExportEngineExtension.php

src/infrastructure/export/PhabricatorExportField.php

src/infrastructure/export/PhabricatorExportFormat.php

src/infrastructure/export/PhabricatorIDExportField.php

src/infrastructure/export/PhabricatorIntExportField.php

src/infrastructure/export/PhabricatorJSONExportFormat.php

src/infrastructure/export/PhabricatorPHIDExportField.php

src/infrastructure/export/PhabricatorStringExportField.php

src/infrastructure/export/PhabricatorTextExportFormat.php

src/infrastructure/export/engine/PhabricatorCustomFieldExportEngineExtension.php

src/infrastructure/export/engine/PhabricatorExportEngineExtension.php

src/infrastructure/export/field/PhabricatorEpochExportField.php

src/infrastructure/export/field/PhabricatorExportField.php

src/infrastructure/export/field/PhabricatorExportFormat.php

src/infrastructure/export/field/PhabricatorIDExportField.php

src/infrastructure/export/field/PhabricatorIntExportField.php

src/infrastructure/export/field/PhabricatorPHIDExportField.php

src/infrastructure/export/format/PhabricatorCSVExportFormat.php

src/infrastructure/export/format/PhabricatorExcelExportFormat.php

src/infrastructure/export/format/PhabricatorJSONExportFormat.php

src/infrastructure/export/format/PhabricatorStringExportField.php

src/infrastructure/export/format/PhabricatorTextExportFormat.php

Organize the export code into subdirectories
ClosedPublic
Actions

Revision Contents
Changeset List