Add a bit of test coverage for bulky vs compact edge data representations
ClosedPublic
Actions

Authored by epriestley on Jan 27 2018, 3:33 PM.

Tags

None

Referenced Files

	F15507927: D18949.id45467.diff
	Wed, Apr 16, 12:19 AM

	F15496999: D18949.id45448.diff
	Sun, Apr 13, 9:16 AM

	F15488941: D18949.id.diff
	Fri, Apr 11, 4:30 AM

	F15487223: D18949.diff
	Thu, Apr 10, 12:22 PM

	F15474835: D18949.diff
	Sun, Apr 6, 12:56 PM

	F15473525: D18949.id45448.diff
	Sat, Apr 5, 11:05 PM

	F15444640: D18949.diff
	Thu, Mar 27, 10:30 AM

	F15436874: D18949.id45467.diff
	Tue, Mar 25, 4:42 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs

Commits

rP1b4017b889e2: (stable) Add a bit of test coverage for bulky vs compact edge data…
rP98402b885b62: Add a bit of test coverage for bulky vs compact edge data representations

Summary

Depends on D18948. Ref T13051. The actual logic ended up so simple that this doesn't really feel terribly valuable, but maybe it'll catch something later on.

Test Plan

Ran test.

Diff Detail

Repository

rP Phabricator

Branch

edge4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19232
Build 25980: Run Core Tests
Build 25979: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 27 2018, 3:33 PM

Harbormaster completed remote builds in B19232: Diff 45448.Jan 27 2018, 3:34 PM

epriestley requested review of this revision.Jan 27 2018, 3:34 PM

amckinley accepted this revision.Jan 29 2018, 7:28 PM

This revision is now accepted and ready to land.Jan 29 2018, 7:28 PM

Closed by commit rP98402b885b62: Add a bit of test coverage for bulky vs compact edge data representations (authored by epriestley). · Explain WhyJan 29 2018, 7:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

infrastructure/

edges/

__tests__/

PhabricatorEdgeChangeRecordTestCase.php

158 lines

Diff 45448

View Options

src/__phutil_library_map__.php

View Options

src/infrastructure/edges/tests/PhabricatorEdgeChangeRecordTestCase.php

Add a bit of test coverage for bulky vs compact edge data representationsClosedPublicActions