Add "you can only enter one value" UI limits to Herald "set status" and "set priority" actions
ClosedPublic
Actions

Authored by epriestley on Jan 26 2018, 5:42 PM.

Details

Reviewers

Maniphest Tasks

T11112: Herald allows setting multiple values in fields that should only accept one value
T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald

Commits

rP4b5a78e3435b: Add "you can only enter one value" UI limits to Herald "set status" and "set…

Summary

Ref T13048. Fixes T11112. I mostly fixed this before in D18887, but missed that these other actions are also affected. T11112 had a more complete list of missing limits.

(It's possible there are some others somewhere, but this is everything we know about, I think.)

Test Plan

Created rules using these actions, typed stuff into the box, was only able to enter one value.

Diff Detail

Repository

rP Phabricator

Branch

heraldx1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19199
Build 25938: Run Core Tests
Build 25937: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 26 2018, 5:42 PM

Harbormaster completed remote builds in B19199: Diff 45418.Jan 26 2018, 5:44 PM

epriestley requested review of this revision.Jan 26 2018, 5:44 PM

amckinley accepted this revision.Jan 26 2018, 9:10 PM

This revision is now accepted and ready to land.Jan 26 2018, 9:10 PM

Closed by commit rP4b5a78e3435b: Add "you can only enter one value" UI limits to Herald "set status" and "set… (authored by epriestley). · Explain WhyJan 26 2018, 9:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

herald/

ManiphestTaskPriorityHeraldAction.php

3 lines

ManiphestTaskStatusHeraldAction.php

3 lines

Diff 45418

View Options

src/applications/maniphest/herald/ManiphestTaskPriorityHeraldAction.php