diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php --- a/src/__phutil_library_map__.php +++ b/src/__phutil_library_map__.php @@ -1362,6 +1362,7 @@ 'HeraldController' => 'applications/herald/controller/HeraldController.php', 'HeraldCoreStateReasons' => 'applications/herald/state/HeraldCoreStateReasons.php', 'HeraldDAO' => 'applications/herald/storage/HeraldDAO.php', + 'HeraldDeprecatedFieldGroup' => 'applications/herald/field/HeraldDeprecatedFieldGroup.php', 'HeraldDifferentialAdapter' => 'applications/differential/herald/HeraldDifferentialAdapter.php', 'HeraldDifferentialDiffAdapter' => 'applications/differential/herald/HeraldDifferentialDiffAdapter.php', 'HeraldDifferentialRevisionAdapter' => 'applications/differential/herald/HeraldDifferentialRevisionAdapter.php', @@ -6560,6 +6561,7 @@ 'HeraldController' => 'PhabricatorController', 'HeraldCoreStateReasons' => 'HeraldStateReasons', 'HeraldDAO' => 'PhabricatorLiskDAO', + 'HeraldDeprecatedFieldGroup' => 'HeraldFieldGroup', 'HeraldDifferentialAdapter' => 'HeraldAdapter', 'HeraldDifferentialDiffAdapter' => 'HeraldDifferentialAdapter', 'HeraldDifferentialRevisionAdapter' => array( diff --git a/src/applications/diffusion/herald/DiffusionCommitReviewerHeraldField.php b/src/applications/diffusion/herald/DiffusionCommitReviewerHeraldField.php --- a/src/applications/diffusion/herald/DiffusionCommitReviewerHeraldField.php +++ b/src/applications/diffusion/herald/DiffusionCommitReviewerHeraldField.php @@ -6,7 +6,11 @@ const FIELDCONST = 'diffusion.commit.reviewer'; public function getHeraldFieldName() { - return pht('Reviewer'); + return pht('Reviewer (Deprecated)'); + } + + public function getFieldGroupKey() { + return HeraldDeprecatedFieldGroup::FIELDGROUPKEY; } public function getHeraldFieldValue($object) { diff --git a/src/applications/herald/field/HeraldDeprecatedFieldGroup.php b/src/applications/herald/field/HeraldDeprecatedFieldGroup.php new file mode 100644 --- /dev/null +++ b/src/applications/herald/field/HeraldDeprecatedFieldGroup.php @@ -0,0 +1,15 @@ +<?php + +final class HeraldDeprecatedFieldGroup extends HeraldFieldGroup { + + const FIELDGROUPKEY = 'deprecated'; + + public function getGroupLabel() { + return pht('Deprecated'); + } + + protected function getGroupOrder() { + return 99999; + } + +}