Differential D18918

Modernize "PhabricatorRepositoryPushLogSearchEngine"
ClosedPublic
Actions

Authored by epriestley on Jan 23 2018, 4:44 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13046: Surface repository pull logs in the web UI

Commits

rP167e7932efb5: Modernize "PhabricatorRepositoryPushLogSearchEngine"

Summary

Depends on D18917. Ref T13046. While I'm in here, update this to use more modern construction.

Test Plan

Browed and queried for push logs.

Diff Detail

Repository

rP Phabricator

Branch

pull5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19136
Build 25841: Run Core Tests
Build 25840: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 23 2018, 4:44 PM

Harbormaster completed remote builds in B19136: Diff 45349.Jan 23 2018, 4:45 PM

epriestley requested review of this revision.Jan 23 2018, 4:45 PM

epriestley added a child revision: D18919: Add a basic, general-purpose export workflow for all objects with SearchEngine support.Jan 23 2018, 6:10 PM

amckinley accepted this revision.Jan 23 2018, 9:07 PM

This revision is now accepted and ready to land.Jan 23 2018, 9:07 PM

Closed by commit rP167e7932efb5: Modernize "PhabricatorRepositoryPushLogSearchEngine" (authored by epriestley). · Explain WhyJan 23 2018, 10:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

query/

PhabricatorRepositoryPushLogSearchEngine.php

71 lines

Diff 45349

View Options

src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php

Modernize "PhabricatorRepositoryPushLogSearchEngine"ClosedPublicActions