Differential D18802

Disallow "Accept" on drafts, allow "Resign"
ClosedPublic
Actions

Authored by epriestley on Nov 28 2017, 7:09 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential

Commits

rP1b76250f8995: Disallow "Accept" on drafts, allow "Resign"

Summary

Depends on D18801. Ref T2543. See PHI229. I missed "Accept" before, but intended to disallow it (like "Reject") since I don't want drafts to be reviewable.

However, "Resign" seems fine to allow? So let's allow that for now.

Test Plan

Was no longer offered "Accept" on draft revisions.

Diff Detail

Repository

rP Phabricator

Branch

draft2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18886
Build 25462: Run Core Tests
Build 25461: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 28 2017, 7:09 PM

Harbormaster completed remote builds in B18886: Diff 45105.Nov 28 2017, 7:10 PM

epriestley requested review of this revision.Nov 28 2017, 7:10 PM

amckinley accepted this revision.Nov 28 2017, 9:22 PM

This revision is now accepted and ready to land.Nov 28 2017, 9:22 PM

Closed by commit rP1b76250f8995: Disallow "Accept" on drafts, allow "Resign" (authored by epriestley). · Explain WhyNov 28 2017, 9:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

xaction/

DifferentialRevisionAcceptTransaction.php

5 lines

DifferentialRevisionResignTransaction.php

5 lines

Diff 45105

View Options

src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php