Differential D18792

Allow MFA enrollment before email verification
ClosedPublic
Actions

Authored by epriestley on Nov 28 2017, 1:36 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T13024: Fix various session initialization order issues

Commits

rPdc62d18b4736: Allow MFA enrollment before email verification

Summary

Depends on D18791. Ref T13024. This clears up another initialization order issue, where an unverified address could prevent MFA enrollment.

Test Plan

Configured both verification required and MFA required, clicked "Add Factor", got a dialog for the workflow.

Diff Detail

Repository

rP Phabricator

Branch

session7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18867
Build 25439: Run Core Tests
Build 25438: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 28 2017, 1:36 AM

Harbormaster completed remote builds in B18867: Diff 45086.Nov 28 2017, 1:37 AM

epriestley requested review of this revision.Nov 28 2017, 1:37 AM

epriestley added a child revision: D18793: Don't show personalized menu items until users establish a full session.Nov 28 2017, 1:59 AM

amckinley accepted this revision.Nov 28 2017, 5:45 PM

This revision is now accepted and ready to land.Nov 28 2017, 5:45 PM

Closed by commit rPdc62d18b4736: Allow MFA enrollment before email verification (authored by epriestley). · Explain WhyNov 28 2017, 6:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

controller/

PhabricatorAuthNeedsMultiFactorController.php

6 lines

Diff 45086

View Options

src/applications/auth/controller/PhabricatorAuthNeedsMultiFactorController.php

Allow MFA enrollment before email verificationClosedPublicActions