Differential D18789

When requiring login signatures, order documents from oldest to newest
ClosedPublic
Actions

Authored by epriestley on Nov 28 2017, 12:55 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T13024: Fix various session initialization order issues

Commits

rPe850bc6b957a: When requiring login signatures, order documents from oldest to newest

Summary

Depends on D18788. Ref T13024. Currently, we prompt users to sign from newest to oldest. This seems less intuitive than oldest to newest.

Test Plan

Dumped document order, saw it swap to oldest-first.

Diff Detail

Repository

rP Phabricator

Branch

session4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18864
Build 25433: Run Core Tests
Build 25432: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 28 2017, 12:55 AM

Harbormaster completed remote builds in B18864: Diff 45083.Nov 28 2017, 12:56 AM

epriestley requested review of this revision.Nov 28 2017, 12:57 AM

epriestley added a child revision: D18790: Ask users to sign Legalpad documents before requiring they enroll in MFA.Nov 28 2017, 1:05 AM

amckinley accepted this revision.Nov 28 2017, 1:18 AM

This revision is now accepted and ready to land.Nov 28 2017, 1:18 AM

Closed by commit rPe850bc6b957a: When requiring login signatures, order documents from oldest to newest (authored by epriestley). · Explain WhyNov 28 2017, 5:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

base/

controller/

PhabricatorController.php

1 line

Diff 45083

View Options

src/applications/base/controller/PhabricatorController.php

When requiring login signatures, order documents from oldest to newestClosedPublicActions