Differential D18788

Refactor on-login Legalpad document signature requirement
ClosedPublic
Actions

Authored by epriestley on Nov 28 2017, 12:53 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T13024: Fix various session initialization order issues

Commits

rPba4b9f71849f: Refactor on-login Legalpad document signature requirement

Summary

Depends on D18786. Ref T13024. I'm going to change the order this occurs in, but move it to a separate method and clean it up a little first.

Test Plan

Added a new document as required, reloaded, signed it, got logged into a session.

Diff Detail

Repository

rP Phabricator

Branch

session3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18863
Build 25431: Run Core Tests
Build 25430: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 28 2017, 12:53 AM

Harbormaster completed remote builds in B18863: Diff 45082.Nov 28 2017, 12:54 AM

epriestley requested review of this revision.Nov 28 2017, 12:54 AM

epriestley added a child revision: D18789: When requiring login signatures, order documents from oldest to newest.Nov 28 2017, 12:55 AM

amckinley accepted this revision.Nov 28 2017, 1:17 AM

This revision is now accepted and ready to land.Nov 28 2017, 1:17 AM

Closed by commit rPba4b9f71849f: Refactor on-login Legalpad document signature requirement (authored by epriestley). · Explain WhyNov 28 2017, 5:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

base/

controller/

PhabricatorController.php

112 lines

Diff 45082

View Options

src/applications/base/controller/PhabricatorController.php

Refactor on-login Legalpad document signature requirementClosedPublicActions