Differential D18786

Lightly modernize LegalpadDocumentSearchEngine
ClosedPublic
Actions

Authored by epriestley on Nov 28 2017, 12:43 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T13024: Fix various session initialization order issues

Commits

rP71406ca93bf4: Lightly modernize LegalpadDocumentSearchEngine

Summary

Depends on D18785. Ref T13024. While I'm in here, update this a bit to use the newer stuff.

Test Plan

Searched for Legalpad documents, saw more modern support (subscribers, order by, viewer()).

Diff Detail

Repository

rP Phabricator

Branch

session2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18861
Build 25427: Run Core Tests
Build 25426: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 28 2017, 12:43 AM

Harbormaster completed remote builds in B18861: Diff 45080.Nov 28 2017, 12:44 AM

epriestley requested review of this revision.Nov 28 2017, 12:44 AM

epriestley added a child revision: D18788: Refactor on-login Legalpad document signature requirement.Nov 28 2017, 12:53 AM

amckinley accepted this revision.Nov 28 2017, 1:16 AM

This revision is now accepted and ready to land.Nov 28 2017, 1:16 AM

Closed by commit rP71406ca93bf4: Lightly modernize LegalpadDocumentSearchEngine (authored by epriestley). · Explain WhyNov 28 2017, 5:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

legalpad/

query/

LegalpadDocumentSearchEngine.php

136 lines

Diff 45080

View Options

src/applications/legalpad/query/LegalpadDocumentSearchEngine.php

Lightly modernize LegalpadDocumentSearchEngineClosedPublicActions