Lightly modernize LegalpadDocumentQuery
ClosedPublic
Actions

Authored by epriestley on Nov 28 2017, 12:12 AM.

Tags

None

Referenced Files

	F15469945: D18785.id45095.diff
	Fri, Apr 4, 6:21 PM

	F15465380: D18785.diff
	Wed, Apr 2, 6:03 PM

	F15460523: D18785.id45095.diff
	Mon, Mar 31, 11:34 PM

	F15458422: D18785.id.diff
	Mon, Mar 31, 12:29 AM

	F15454424: D18785.diff
	Sat, Mar 29, 6:28 PM

	F15324753: D18785.id45079.diff
	Fri, Mar 7, 1:53 AM

	Unknown Object (File)
	Feb 9 2025, 4:51 AM

	Unknown Object (File)
	Feb 9 2025, 4:51 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13024: Fix various session initialization order issues

Commits

rP3d742eb50baf: Lightly modernize LegalpadDocumentQuery

Summary

Ref T13024. Updates LegalpadDocumentQuery to use slightly more modern constructions.

Test Plan

Queried for Legalpad documents, got the same results.

Diff Detail

Repository

rP Phabricator

Branch

session1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18860
Build 25425: Run Core Tests
Build 25424: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 28 2017, 12:12 AM

Harbormaster completed remote builds in B18860: Diff 45079.Nov 28 2017, 12:13 AM

epriestley requested review of this revision.Nov 28 2017, 12:13 AM

epriestley added a child revision: D18786: Lightly modernize LegalpadDocumentSearchEngine.Nov 28 2017, 12:43 AM

amckinley accepted this revision.Nov 28 2017, 1:14 AM

This revision is now accepted and ready to land.Nov 28 2017, 1:14 AM

Closed by commit rP3d742eb50baf: Lightly modernize LegalpadDocumentQuery (authored by epriestley). · Explain WhyNov 28 2017, 5:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

legalpad/

query/

LegalpadDocumentQuery.php

71 lines

Diff 45079

View Options

src/applications/legalpad/query/LegalpadDocumentQuery.php

Lightly modernize LegalpadDocumentQueryClosedPublicActions