Page MenuHomePhabricator

Rename "arc diff --preview" to "arc diff --only"
ClosedPublic

Authored by epriestley on Oct 27 2017, 4:25 PM.
Tags
None
Referenced Files
F13092687: D18740.diff
Thu, Apr 25, 4:28 AM
F13087496: D18740.diff
Thu, Apr 25, 12:59 AM
Unknown Object (File)
Mon, Apr 22, 9:07 PM
Unknown Object (File)
Fri, Apr 19, 6:56 PM
Unknown Object (File)
Thu, Apr 18, 7:30 PM
Unknown Object (File)
Thu, Apr 11, 6:14 AM
Unknown Object (File)
Sun, Apr 7, 7:38 AM
Unknown Object (File)
Sat, Mar 30, 5:22 AM
Subscribers
None

Details

Summary

Experimental branch. Depends on D18739. Ref T2543.

To prepare for --draft, consolidate --preview and --only.

The old --preview is now arc diff --only.

The old --only is now arc diff --only --nounit --nolint.

I think this is more clear than other ways we could do it, since the difference between "draft" and "preview" seems less clear than the difference between "draft" and "only".

Test Plan

Ran arc diff --only and arc diff --only --nounit --nolint.

Diff Detail

Repository
rARC Arcanist
Branch
draft4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18759
Build 25279: Run Core Tests
Build 25278: arc lint + arc unit