Add a missing `artifactIndex` key to HarbormasterBuildArtifact
ClosedPublic
Actions

Authored by epriestley on Oct 26 2017, 8:03 PM.

Details

Reviewers

amckinley

Commits

rPa03da0c2afe4: Add a missing `artifactIndex` key to HarbormasterBuildArtifact

Summary

See PHI176. We issue a query with only artifactIndex from BuildTarget, but don't have an applicable key.

Test Plan

This isn't on the normal Harbormaster execution path so I'm not 100% sure I have a local repro, but will confirm with customer.

Diff Detail

Repository

rP Phabricator

Branch

key1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18744
Build 25256: Run Core Tests
Build 25255: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 26 2017, 8:03 PM

Owners added a subscriber: Restricted Owners Package.Oct 26 2017, 8:03 PM

Harbormaster requested review of this revision.Oct 26 2017, 8:04 PM

Harbormaster completed remote builds in B18744: Diff 44963.

Unrelated to the revision itself, but this is weird:

Screen Shot 2017-10-26 at 2.32.32 PM.png (394×1 px, 77 KB)

This revision is now accepted and ready to land.Oct 26 2017, 9:33 PM

I hadn't pushed D18730 yet, but going forward that should say "epriestley requested..." instead of "Harbormaster requested...", unless you were pointing out something else.

Closed by commit rPa03da0c2afe4: Add a missing `artifactIndex` key to HarbormasterBuildArtifact (authored by epriestley). · Explain WhyOct 27 2017, 1:18 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

storage/

build/

HarbormasterBuildArtifact.php

3 lines

Diff 44963

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildArtifact.php

Add a missing `artifactIndex` key to HarbormasterBuildArtifactClosedPublicActions