Correct a method signature in DifferentialDraftField
ClosedPublic
Actions

Authored by epriestley on Oct 23 2017, 5:14 PM.

Details

Reviewers

Maniphest Tasks

T12190: In PHP7, include-time warnings from source files are ignored

Commits

rP5975b9d28e41: (stable) Correct a method signature in DifferentialDraftField
rPe3a48dde1d5b: Correct a method signature in DifferentialDraftField

Summary

Ref T12190. See https://discourse.phabricator-community.org/t/exception-preventing-access-to-differential-application/606.

(I have a followup to fix the root issue.)

Test Plan

Loaded Differential with an eye on the error log in PHP7, no longer saw warnings.

Diff Detail

Repository

rP Phabricator

Branch

methodsig1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18723
Build 25227: Run Core Tests
Build 25226: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.Oct 23 2017, 5:14 PM

epriestley created this revision.

Harbormaster completed remote builds in B18723: Diff 44943.Oct 23 2017, 5:15 PM

epriestley mentioned this in D18724: Convert all "include_once" warnings into exceptions in all PHP versions.Oct 23 2017, 5:17 PM

amckinley accepted this revision.Oct 23 2017, 5:33 PM

This revision is now accepted and ready to land.Oct 23 2017, 5:33 PM

Closed by commit rPe3a48dde1d5b: Correct a method signature in DifferentialDraftField (authored by epriestley). · Explain WhyOct 23 2017, 5:33 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rPHU95c065963998: Convert all "include_once" warnings into exceptions in all PHP versions.Oct 23 2017, 5:54 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialDraftField.php

2 lines

Diff 44943

View Options

src/applications/differential/customfield/DifferentialDraftField.php

Correct a method signature in DifferentialDraftFieldClosedPublicActions