Page MenuHomePhabricator

Add "persistence" types (data, cache, or index) to tables, and tweak what "storage dump" dumps
ClosedPublic

Authored by epriestley on Oct 4 2017, 6:58 PM.

Details

Summary

Ref T13000. This marks each table as either "data" (normal data), "cache" (automatically rebuilt, no need to ever dump) or "index" (can be manually rebuilt).

By default, bin/storage dump dumps data and index tables, but not cache tables.

With --no-indexes, it dumps only data tables. Indexes can be rebuilt after a restore with bin/search index --all ....

Test Plan
  • Ran --no-indexes and normal dumps with --trace, verified that cache and index (former case) or cache only (latter case) tables were dumped with --no-data.
  • Verified dump has the same number of CREATE TABLE statements as before the changes.
  • Reviewed persistence tags in the web UI (note Ferret engine tables are "Index"):

Screen Shot 2017-10-04 at 11.18.30 AM.png (499×890 px, 78 KB)

Diff Detail

Repository
rP Phabricator
Branch
dump2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18633
Build 25103: Run Core Tests
Build 25102: arc lint + arc unit