Page MenuHomePhabricator

Support automatic "Depends On" detection in Mercurial
ClosedPublic

Authored by epriestley on Sep 27 2017, 5:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 18, 7:56 PM
Unknown Object (File)
Mon, Mar 11, 2:23 AM
Unknown Object (File)
Feb 26 2024, 4:08 PM
Unknown Object (File)
Jan 10 2024, 2:01 PM
Unknown Object (File)
Dec 27 2023, 12:14 PM
Unknown Object (File)
Dec 27 2023, 12:13 PM
Unknown Object (File)
Dec 27 2023, 12:13 PM
Unknown Object (File)
Dec 21 2023, 9:53 PM
Subscribers

Details

Summary

Depends on D18651. Allows Mercurial to auto-detect depends-on revisions.

Test Plan

See D18652 and D18653. Didn't actually test the empty repository states but they're probably okay. The experimental branch is an untamed wild. ¯\_(ツ)_/¯

Diff Detail

Repository
rARC Arcanist
Branch
dep2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18561
Build 25005: Run Core Tests
Build 25004: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 27 2017, 5:31 PM
This revision was automatically updated to reflect the committed changes.

I'm checking this out nowish. Will let you know what beasts I run into in the wilderness of the experimental branch.

For the initial arc diff it seemed to work. I got a commit message pre-populated with Depends On: Dxxxx.

I ran into some strange PhutilConsole import errors on second update but when I came here to report they become non-reproducible so I'll keep my eye open for them but no other issues so far.

If you still have the error text I might be able to hunt them down.

(PhutilConsole should mostly get nuked in T12996 so they probably won't survive that anyway.)