Differential D18633

Update an old SSH redirect URI when editing a bot's SSH keys
ClosedPublic
Actions

Authored by epriestley on Sep 20 2017, 9:39 PM.

Tags

None

Referenced Files

	F14406470: D18633.diff
	Mon, Dec 23, 2:28 PM

	Unknown Object (File)
	Wed, Dec 18, 12:54 PM

	Unknown Object (File)
	Thu, Dec 12, 1:15 AM

	Unknown Object (File)
	Oct 25 2024, 2:55 AM

	Unknown Object (File)
	Oct 21 2024, 8:01 AM

	Unknown Object (File)
	Oct 15 2024, 1:54 PM

	Unknown Object (File)
	Oct 14 2024, 1:31 PM

	Unknown Object (File)
	Sep 10 2024, 3:35 AM

Subscribers

None

Details

Reviewers

Commits

rPf089f41e50c6: (stable) Update an old SSH redirect URI when editing a bot's SSH keys
rP5112dac491a8: Update an old SSH redirect URI when editing a bot's SSH keys

Summary

See PHI79. When you edit another user's SSH keys (normally, for a bot account) we currently redirect you to an older URI.

Test Plan

Viewed a bot's profile page.
Clicked "Edit Settings" on the Manage page.
Went to "SSH Keys".
Uploaded an SSH key.
Before: redirected to a 404 after finishing the workflow.
After: redirected to the same page after the workflow.

Diff Detail

Repository

Branch

sshredirect1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18510
Build 24930: Run Core Tests
Build 24929: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 20 2017, 9:39 PM

Harbormaster completed remote builds in B18510: Diff 44733.Sep 20 2017, 9:40 PM

amckinley accepted this revision.Sep 20 2017, 9:46 PM

This revision is now accepted and ready to land.Sep 20 2017, 9:46 PM

Closed by commit rP5112dac491a8: Update an old SSH redirect URI when editing a bot's SSH keys (authored by epriestley). · Explain WhySep 20 2017, 9:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

storage/

PhabricatorUser.php

2 lines

Diff 44733

src/applications/people/storage/PhabricatorUser.php

Loading...