Paths

Table of Contentst

Differential D18522

Minor bug fix with PHUIInfoView
ClosedPublic
Actions

Authored by chad on Sep 3 2017, 4:41 PM.

Details

Reviewers

epriestley

Commits

rP5ceca721cce3: Minor bug fix with PHUIInfoView

Summary

Custom icons here aren't being set. Also use more standard tt UI.

Test Plan

Set an icon, see set Icon.

Diff Detail

Repository

rP Phabricator

Branch

info-view-tweaks (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18269
Build 24574: Run Core Tests
Build 24573: arc lint + arc unit

Event Timeline

chad created this revision.Sep 3 2017, 4:41 PM

Harbormaster completed remote builds in B18269: Diff 44485.Sep 3 2017, 4:41 PM

Herald added a subscriber: Korvin. · View Herald TranscriptSep 3 2017, 4:41 PM

Harbormaster completed remote builds in B18269: Diff 44485.Sep 3 2017, 4:42 PM

epriestley accepted this revision.Sep 5 2017, 1:10 PM

This revision is now accepted and ready to land.Sep 5 2017, 1:10 PM

Closed by commit rP5ceca721cce3: Minor bug fix with PHUIInfoView (authored by Chad Little <chad@phacility.com>). · Explain WhySep 5 2017, 5:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

src/

view/

phui/

PHUIInfoView.php

1 line

webroot/

rsrc/

css/

phui/

phui-info-view.css

7 lines

Diff 44485

View Options

resources/celerity/map.php

View Options

src/view/phui/PHUIInfoView.php

View Options

webroot/rsrc/css/phui/phui-info-view.css

Minor bug fix with PHUIInfoViewClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44485

resources/celerity/map.php

src/view/phui/PHUIInfoView.php

webroot/rsrc/css/phui/phui-info-view.css

Minor bug fix with PHUIInfoView
ClosedPublic
Actions

Revision Contents
Changeset List