Add "title:..." support to the Ferret engine
ClosedPublic
Actions

Authored by epriestley on Aug 30 2017, 5:12 PM.

Details

Reviewers

chad

Maniphest Tasks

T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size

Commits

rP3b43a7077345: Add "title:..." support to the Ferret engine

Summary

Ref T12819. Adds (hacky, hard-coded) field support (for now, only for "title").

I've written this so title:quick ferret is the same as title:quick title:ferret. I think this is what users probably mean.

You can do the other thing as ferret title:quick, or title:quick all:ferret.

Test Plan

Searched for title:x, title:"x", title:~"x", etc. Searched for "garbage:y", got an exception since that's not a recognized function. Searched for title:x y, saw both do title search.

Diff Detail

Repository

rP Phabricator

Branch

ferret9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18221
Build 24505: Run Core Tests
Build 24504: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 30 2017, 5:12 PM

Harbormaster completed remote builds in B18221: Diff 44436.Aug 30 2017, 5:14 PM

chad accepted this revision.Aug 30 2017, 5:26 PM

This revision is now accepted and ready to land.Aug 30 2017, 5:26 PM

Closed by commit rP3b43a7077345: Add "title:..." support to the Ferret engine (authored by epriestley). · Explain WhyAug 30 2017, 6:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

query/

policy/

PhabricatorCursorPagedPolicyAwareQuery.php

83 lines

Diff 44436

View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Add "title:..." support to the Ferret engineClosedPublicActions