Provide some "term vs substring" support for the Ferret engine
ClosedPublic
Actions

Authored by epriestley on Aug 30 2017, 4:29 PM.

Details

Reviewers

chad

Maniphest Tasks

T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size

Commits

rPdf9c24e75058: Provide some "term vs substring" support for the Ferret engine

Summary

Ref T12819. Distinguishes between "term" queries and "substring" queries, and tries to match them correctly most of the time. For example:

example matches "example", obviously.
~amp matches "example", but amp does not.
examples matches "example" through stemming.
"examples" does not match "example" (quoted text does not stem).
"an examp" does not match "an example" (quoted text is still term text).
~"an examp" matches "an example" (quoted, substring-operator text uses substring search).

Test Plan

Ran searches similar to the above, they seemed to do what they should.

Diff Detail

Repository

rP Phabricator

Branch

ferret7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18217
Build 24497: Run Core Tests
Build 24496: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 30 2017, 4:29 PM

Harbormaster completed remote builds in B18217: Diff 44432.Aug 30 2017, 4:30 PM

The code is pretty hacks-upon-hacks, but I'm still not really sure if this is a viable pathway forward or not so I'm trying to get it all working before I clean it up. Stuff I still have to do:

Make title: work (search only the title field).
Make dog -blue (negated terms) work.

Then we can bang on it a bit and see if it falls over. If it seems like it's going to hold, I'll clean things up a bit so the code, e.g., isn't adding random spaces to things for no apparent reason in 50 different places (the spaces are "magic").