Page MenuHomePhabricator
Differential D18475

Fix fatal on logged out Phame Post
ClosedPublic
Actions

Authored by chad on Aug 25 2017, 3:39 AM.
Tags
None
Referenced Files
F18751110: D18475.id44386.diff
Sat, Oct 4, 9:47 AM
F18750562: D18475.id44383.diff
Sat, Oct 4, 8:14 AM
F18750558: D18475.id44387.diff
Sat, Oct 4, 8:13 AM
F18748554: D18475.diff
Fri, Oct 3, 11:23 PM
F18628945: D18475.diff
Tue, Sep 16, 7:39 AM
F18509020: D18475.id.diff
Fri, Sep 5, 3:09 AM
F18501446: D18475.diff
Thu, Sep 4, 9:45 PM
F18131782: D18475.id44387.diff
Aug 13 2025, 8:59 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP79c6b5004914: Fix fatal on logged out Phame Post
Summary

Just deletes the view code until I have time to better plan this out, or just not ship.

Test Plan

Visit Phame post on public logged out page, view count doesnt cause transaction fatal.

Diff Detail

Repository
rP Phabricator
Branch
phame-logged-out (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18173
Build 24430: Run Core Tests
Build 24429: arc lint + arc unit

Event Timeline

chad created this revision.Aug 25 2017, 3:39 AM
Herald added a subscriber: Korvin. · View Herald TranscriptAug 25 2017, 3:39 AM
Harbormaster completed remote builds in B18170: Diff 44383.Aug 25 2017, 3:40 AM
epriestley accepted this revision.Aug 25 2017, 3:50 AM
This revision is now accepted and ready to land.Aug 25 2017, 3:50 AM
chad planned changes to this revision.Aug 25 2017, 4:33 AM

I'll just remove the transaction in the morning.

chad updated this revision to Diff 44386.Aug 25 2017, 3:31 PM
  • remove phame views
This revision is now accepted and ready to land.Aug 25 2017, 3:31 PM
Harbormaster completed remote builds in B18173: Diff 44386.Aug 25 2017, 3:33 PM
chad edited the summary of this revision. (Show Details)Aug 25 2017, 3:37 PM
chad edited the test plan for this revision. (Show Details)
epriestley accepted this revision.Aug 25 2017, 3:40 PM
Closed by commit rP79c6b5004914: Fix fatal on logged out Phame Post (authored by Chad Little <chad@phacility.com>). · Explain WhyAug 25 2017, 3:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
2 lines
applications/
phame/
controller/
post/
24 lines
editor/
12 lines
storage/
5 lines
xaction/

Diff 44386

View Options

resources/sql/autopatches/20170825.phame.01.post.views.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostViewController.php

Loading...
View Options

src/applications/phame/editor/PhamePostEditor.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
View Options

src/applications/phame/xaction/PhamePostViewsTransaction.php

Loading...
Phabricator · Built by Phacility