Differential D18475

Fix fatal on logged out Phame Post
ClosedPublic
Actions

Authored by chad on Aug 25 2017, 3:39 AM.

Details

Reviewers

epriestley

Commits

rP79c6b5004914: Fix fatal on logged out Phame Post

Summary

Just deletes the view code until I have time to better plan this out, or just not ship.

Test Plan

Visit Phame post on public logged out page, view count doesnt cause transaction fatal.

Diff Detail

Repository

rP Phabricator

Branch

phame-logged-out (branched from master)

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/phame/controller/post/PhamePostViewController.php:22	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 18170
Build 24425: Run Core Tests
Build 24424: arc lint + arc unit

Event Timeline

chad created this revision.Aug 25 2017, 3:39 AM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 25 2017, 3:39 AM

Harbormaster completed remote builds in B18170: Diff 44383.Aug 25 2017, 3:40 AM

epriestley accepted this revision.Aug 25 2017, 3:50 AM

This revision is now accepted and ready to land.Aug 25 2017, 3:50 AM

I'll just remove the transaction in the morning.

remove phame views

This revision is now accepted and ready to land.Aug 25 2017, 3:31 PM

Harbormaster completed remote builds in B18173: Diff 44386.Aug 25 2017, 3:33 PM

chad edited the summary of this revision. (Show Details)Aug 25 2017, 3:37 PM

chad edited the test plan for this revision. (Show Details)

epriestley accepted this revision.Aug 25 2017, 3:40 PM

Closed by commit rP79c6b5004914: Fix fatal on logged out Phame Post (authored by Chad Little <chad@phacility.com>). · Explain WhyAug 25 2017, 3:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

controller/

post/

PhamePostViewController.php

4 lines

Diff 44383

View Options

src/applications/phame/controller/post/PhamePostViewController.php

Fix fatal on logged out Phame PostClosedPublicActions