Page MenuHomePhabricator

Move all revision status transactions to modern values and mechanics
ClosedPublic

Authored by epriestley on Aug 12 2017, 12:03 AM.
Tags
None
Referenced Files
F14756146: D18419.id44263.diff
Tue, Jan 21, 7:10 PM
Unknown Object (File)
Tue, Jan 21, 3:16 PM
Unknown Object (File)
Tue, Jan 21, 12:39 PM
Unknown Object (File)
Fri, Jan 17, 12:21 PM
Unknown Object (File)
Sat, Jan 11, 8:59 AM
Unknown Object (File)
Dec 17 2024, 6:55 AM
Unknown Object (File)
Dec 12 2024, 8:56 AM
Unknown Object (File)
Dec 12 2024, 8:56 AM
Subscribers
None

Details

Summary

Ref T2543. This updates and migrates the status change transactions:

  • All storage now records the modern modular transaction ("differential.revision.status"), not the obsolete non-modular transaction ("differential:status").
  • All storage now records the modern constants ("accepted"), not the obsolete numeric values ("2").
Test Plan
  • Selected all the relevant rows before/after migration, data looked sane.
  • Browsed around, reviewed timelines, no changes after migration.
  • Changed revision states, saw appropriate new transactions in the database and timeline rendering.
  • Grepped for differential:status.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable