Page MenuHomePhabricator

Move all revision status transactions to modern values and mechanics
ClosedPublic

Authored by epriestley on Aug 12 2017, 12:03 AM.
Tags
None
Referenced Files
F13180392: D18419.id44263.diff
Wed, May 8, 11:40 PM
Unknown Object (File)
Tue, May 7, 9:24 AM
Unknown Object (File)
Sun, May 5, 8:43 AM
Unknown Object (File)
Fri, May 3, 9:11 AM
Unknown Object (File)
Sun, Apr 28, 6:22 AM
Unknown Object (File)
Thu, Apr 25, 2:49 AM
Unknown Object (File)
Fri, Apr 19, 6:44 PM
Unknown Object (File)
Thu, Apr 11, 10:08 AM
Subscribers
None

Details

Summary

Ref T2543. This updates and migrates the status change transactions:

  • All storage now records the modern modular transaction ("differential.revision.status"), not the obsolete non-modular transaction ("differential:status").
  • All storage now records the modern constants ("accepted"), not the obsolete numeric values ("2").
Test Plan
  • Selected all the relevant rows before/after migration, data looked sane.
  • Browsed around, reviewed timelines, no changes after migration.
  • Changed revision states, saw appropriate new transactions in the database and timeline rendering.
  • Grepped for differential:status.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable