Page MenuHomePhabricator

Move all revision status transactions to modern values and mechanics
ClosedPublic

Authored by epriestley on Aug 12 2017, 12:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 29, 7:52 AM
Unknown Object (File)
Sat, Jun 28, 6:17 PM
Unknown Object (File)
Jun 3 2025, 2:55 AM
Unknown Object (File)
May 31 2025, 9:00 PM
Unknown Object (File)
May 31 2025, 9:00 PM
Unknown Object (File)
May 31 2025, 11:01 AM
Unknown Object (File)
May 30 2025, 2:38 PM
Unknown Object (File)
May 29 2025, 7:35 AM
Subscribers
None

Details

Summary

Ref T2543. This updates and migrates the status change transactions:

  • All storage now records the modern modular transaction ("differential.revision.status"), not the obsolete non-modular transaction ("differential:status").
  • All storage now records the modern constants ("accepted"), not the obsolete numeric values ("2").
Test Plan
  • Selected all the relevant rows before/after migration, data looked sane.
  • Browsed around, reviewed timelines, no changes after migration.
  • Changed revision states, saw appropriate new transactions in the database and timeline rendering.
  • Grepped for differential:status.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable