Page MenuHomePhabricator

Move all revision status transactions to modern values and mechanics
ClosedPublic

Authored by epriestley on Aug 12 2017, 12:03 AM.
Tags
None
Referenced Files
F19150654: D18419.id44254.diff
Wed, Dec 10, 9:34 PM
F19082466: D18419.id44263.diff
Dec 2 2025, 11:14 AM
F19078762: D18419.id.diff
Dec 1 2025, 7:11 PM
F19047518: D18419.id44254.diff
Nov 27 2025, 1:03 PM
F19046616: D18419.id44254.diff
Nov 27 2025, 11:09 AM
F18841187: D18419.id.diff
Oct 28 2025, 7:33 AM
F18839742: D18419.diff
Oct 27 2025, 6:37 PM
F18830305: D18419.id.diff
Oct 25 2025, 5:59 AM
Subscribers
None

Details

Summary

Ref T2543. This updates and migrates the status change transactions:

  • All storage now records the modern modular transaction ("differential.revision.status"), not the obsolete non-modular transaction ("differential:status").
  • All storage now records the modern constants ("accepted"), not the obsolete numeric values ("2").
Test Plan
  • Selected all the relevant rows before/after migration, data looked sane.
  • Browsed around, reviewed timelines, no changes after migration.
  • Changed revision states, saw appropriate new transactions in the database and timeline rendering.
  • Grepped for differential:status.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable