Move all revision status transactions to modern values and mechanics
ClosedPublic
Actions

Authored by epriestley on Aug 12 2017, 12:03 AM.

Details

Reviewers

chad

Maniphest Tasks

Commits

Summary

Ref T2543. This updates and migrates the status change transactions:

All storage now records the modern modular transaction ("differential.revision.status"), not the obsolete non-modular transaction ("differential:status").
All storage now records the modern constants ("accepted"), not the obsolete numeric values ("2").

Test Plan

Selected all the relevant rows before/after migration, data looked sane.
Browsed around, reviewed timelines, no changes after migration.
Changed revision states, saw appropriate new transactions in the database and timeline rendering.
Grepped for differential:status.

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

This revision is now accepted and ready to land.Aug 12 2017, 12:56 AM

This revision was automatically updated to reflect the committed changes.

		Path
A	M	resources/sql/autopatches/20170811.differential.03.modernxaction.php (38 lines)
M		src/applications/differential/constants/DifferentialRevisionStatus.php (21 lines)
M		src/applications/differential/editor/DifferentialTransactionEditor.php (16 lines)
M		src/applications/differential/storage/DifferentialTransaction.php (13 lines)
M		src/applications/differential/xaction/DifferentialRevisionStatusTransaction.php (6 lines)