Page MenuHomePhabricator

Move all revision status transactions to modern values and mechanics
ClosedPublic

Authored by epriestley on Aug 12 2017, 12:03 AM.
Tags
None
Referenced Files
F18696635: D18419.id44254.diff
Sat, Sep 27, 8:09 AM
F18642177: D18419.diff
Thu, Sep 18, 10:49 PM
F18509007: D18419.id.diff
Sep 5 2025, 3:09 AM
F18501430: D18419.diff
Sep 4 2025, 9:45 PM
F18216426: D18419.id.diff
Aug 19 2025, 7:42 AM
F18207384: D18419.diff
Aug 18 2025, 6:16 PM
F18124749: D18419.id44263.diff
Aug 13 2025, 12:44 PM
F18124744: D18419.id44254.diff
Aug 13 2025, 12:44 PM
Subscribers
None

Details

Summary

Ref T2543. This updates and migrates the status change transactions:

  • All storage now records the modern modular transaction ("differential.revision.status"), not the obsolete non-modular transaction ("differential:status").
  • All storage now records the modern constants ("accepted"), not the obsolete numeric values ("2").
Test Plan
  • Selected all the relevant rows before/after migration, data looked sane.
  • Browsed around, reviewed timelines, no changes after migration.
  • Changed revision states, saw appropriate new transactions in the database and timeline rendering.
  • Grepped for differential:status.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable