Paths

Table of Contentst

Completely remove "differential.find" Conduit API method
ClosedPublic
Actions

Authored by epriestley on Aug 11 2017, 4:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 17, 10:07 PM

	Unknown Object (File)
	Wed, Apr 17, 3:15 PM

	Unknown Object (File)
	Thu, Apr 11, 7:23 AM

	Unknown Object (File)
	Sun, Apr 7, 7:45 AM

	Unknown Object (File)
	Sat, Apr 6, 6:56 AM

	Unknown Object (File)
	Sun, Mar 31, 4:11 AM

	Unknown Object (File)
	Sat, Mar 30, 4:55 AM

	Unknown Object (File)
	Thu, Mar 28, 6:11 AM

View All 96 Files

Subscribers

None

Tokens

"Burninate" token, awarded by chad.

Details

Reviewers

chad

Maniphest Tasks

T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential

Commits

rP42020e135767: Completely remove "differential.find" Conduit API method

Summary

Ref T2543. I believe there have been no upstream callsites of this method since D1646, in February 2012.

The method works, and we can revert this if needbe, but this seems like a good time to remove support.

Test Plan

Grepped for differential.find.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 11 2017, 4:34 PM

Harbormaster completed remote builds in B18010: Diff 44212.Aug 11 2017, 4:35 PM

chad accepted this revision.Aug 11 2017, 5:14 PM

This revision is now accepted and ready to land.Aug 11 2017, 5:14 PM

chad awarded a token.Aug 11 2017, 5:15 PM

Closed by commit rP42020e135767: Completely remove "differential.find" Conduit API method (authored by epriestley, committed by epriestley). · Explain WhyAug 11 2017, 8:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

differential/

conduit/

DifferentialFindConduitAPIMethod.php

Diff 44239

View Options

src/__phutil_library_map__.php