Page MenuHomePhabricator
Differential D18395

Replace legacy Differential queries for "open" revisions with a modern mechanism
ClosedPublic
Actions

Authored by epriestley on Aug 11 2017, 4:20 PM.
Tags
None
Referenced Files
F15414337: D18395.diff
Thu, Mar 20, 12:10 AM
F15408190: D18395.id44236.diff
Tue, Mar 18, 9:36 PM
F15403568: D18395.diff
Tue, Mar 18, 3:55 AM
F15383919: D18395.diff
Fri, Mar 14, 6:19 PM
Unknown Object (File)
Feb 12 2025, 9:58 PM
Unknown Object (File)
Feb 12 2025, 9:56 PM
Unknown Object (File)
Feb 8 2025, 9:51 AM
Unknown Object (File)
Feb 8 2025, 8:30 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential
Commits
rP50dfdb8d0355: Replace legacy Differential queries for "open" revisions with a modern mechanism
Summary

Ref T2543. Several queries want only open revisions. Provide a tailored, non-legacy way to issue that query.

Test Plan

Viewed some of these callsites (e.g., "Similar open revisions affecting these files"), saw only open revisions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
2 lines
2 lines
query/
20 lines
2 lines
diffusion/
controller/
2 lines

Diff 44236

View Options

src/applications/differential/controller/DifferentialDiffViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility