Page MenuHomePhabricator

Pull legacy revision query status filters out of the main Query class
ClosedPublic

Authored by epriestley on Aug 4 2017, 5:30 PM.
Tags
None
Referenced Files
F15390965: D18343.id44097.diff
Sat, Mar 15, 7:33 AM
F15369074: D18343.diff
Wed, Mar 12, 5:14 AM
Unknown Object (File)
Feb 15 2025, 1:31 AM
Unknown Object (File)
Jan 28 2025, 1:14 AM
Unknown Object (File)
Jan 27 2025, 12:34 PM
Unknown Object (File)
Jan 26 2025, 11:42 PM
Unknown Object (File)
Jan 25 2025, 10:36 AM
Unknown Object (File)
Jan 21 2025, 12:57 PM
Subscribers
None

Details

Summary

Ref T2543. Currently, Differential uses a set of hard-coded query filters (like "open" and "closed") to query revisions by status (for example, "open" means any of "review, revision, changes planned, accepted [usually]").

In other applications, like Maniphest, we've replaced this with a low level list of the actual statuses, plus higher level convenience UI through tokenizer functions. This basically has all of the benefits of the hard-coded filters with none of the drawbacks, and is generally more flexible.

I'd like to do that in Differential, too, although we'll need to keep the legacy maps around for a while because they're used by differential.find and differential.getrevision. To prepare for this, pull all the legacy stuff out into a separate class. Then I'll modernize where I can, and we can get rid of this junk some day.

Test Plan

Grepped for RevisionQuery::STATUS. Ran queries via Differential UI.

Diff Detail

Repository
rP Phabricator
Branch
status4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17912
Build 24057: Run Core Tests
Build 24056: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 4 2017, 6:34 PM
This revision was automatically updated to reflect the committed changes.