Differential D18274

Make "A" hide or show all inline comments
ClosedPublic
Actions

Authored by epriestley on Jul 24 2017, 11:31 PM.

Details

Reviewers

chad

Maniphest Tasks

T12733: (2017 Week 20) Inline Comments Errata / Feedback

Commits

rPc217d7619c5f: Make "A" hide or show all inline comments

Summary

Ref T12733. See PHI17.

Test Plan

Pressed "A", then pressed "A".

Diff Detail

Repository

rP Phabricator

Branch

keyboard1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17795
Build 23897: Run Core Tests
Build 23896: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 24 2017, 11:31 PM

Harbormaster completed remote builds in B17795: Diff 43949.Jul 24 2017, 11:32 PM

Slightly smaller/simpler diff

Harbormaster completed remote builds in B17796: Diff 43950.Jul 24 2017, 11:33 PM

chad accepted this revision.Jul 25 2017, 2:40 AM

This revision is now accepted and ready to land.Jul 25 2017, 2:40 AM

Closed by commit rPc217d7619c5f: Make "A" hide or show all inline comments (authored by epriestley, committed by epriestley). · Explain WhyJul 25 2017, 12:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

14 lines

src/

applications/

differential/

view/

DifferentialChangesetListView.php

3 lines

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

23 lines

Diff 43949

View Options

resources/celerity/map.php

View Options

src/applications/differential/view/DifferentialChangesetListView.php

View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Make "A" hide or show all inline commentsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43949

resources/celerity/map.php

src/applications/differential/view/DifferentialChangesetListView.php

webroot/rsrc/js/application/diff/DiffChangesetList.js

Make "A" hide or show all inline comments
ClosedPublic
Actions

Revision Contents
Changeset List