Page MenuHomePhabricator

Rudamentary PHUILeftRightView
ClosedPublic

Authored by chad on Jul 10 2017, 11:04 PM.
Tags
None
Referenced Files
F13148136: D18200.diff
Fri, May 3, 8:59 PM
F13145721: D18200.diff
Fri, May 3, 9:16 AM
Unknown Object (File)
Sat, Apr 27, 11:20 PM
Unknown Object (File)
Sat, Apr 27, 11:19 PM
Unknown Object (File)
Sat, Apr 27, 11:14 PM
Unknown Object (File)
Sat, Apr 27, 11:05 PM
Unknown Object (File)
Thu, Apr 25, 2:54 AM
Unknown Object (File)
Thu, Apr 11, 10:22 AM
Subscribers

Details

Summary

First pass at providing a skeleton framework for laying out basic items in a left/right view. Will likely add some mobile-responsive options.

Test Plan

UIExamples

Diff Detail

Repository
rP Phabricator
Branch
phui-left-right (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17667
Build 23719: Run Core Tests
Build 23718: arc lint + arc unit

Event Timeline

Presumably future changes will make this clear, but what's this for / what's different between "left right" and "two column"?

This revision is now accepted and ready to land.Jul 10 2017, 11:15 PM

Oh I guess I could probably answer that question myself by looking at the example.

Hmm still not entirely sure. 🍧

PHUITwoColumn is a two column page layout tool (side column is fixed width, responsiveness is based on that specifically). This is more a simple UI widget I plan to use for smaller layout needs like floating a header and button in various places.

There's no :shrug: so that's what you get. 🐦

This revision was automatically updated to reflect the committed changes.