Differential D18182

Fix several pieces of UI language describing "draft/archive" rules in Phame
ClosedPublic
Actions

Authored by epriestley on Jul 5 2017, 4:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 8:37 AM

	Unknown Object (File)
	Tue, Dec 17, 1:34 PM

	Unknown Object (File)
	Thu, Dec 12, 12:53 AM

	Unknown Object (File)
	Fri, Dec 6, 11:21 AM

	Unknown Object (File)
	Fri, Nov 29, 8:33 AM

	Unknown Object (File)
	Sun, Nov 24, 4:35 PM

	Unknown Object (File)
	Nov 21 2024, 12:34 PM

	Unknown Object (File)
	Nov 17 2024, 7:06 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors

Commits

rP8d11e127ff15: Fix several pieces of UI language describing "draft/archive" rules in Phame

Summary

Ref T12900. We implement one rule, but tell users a different (older) rule. See T12900 for discussion and history.

Test Plan

Verified draft/archived posts can't be seen by users who don't have permission to edit the blog.
Drafted, archived, and published posts and read the related text.
Looked through the changes I dug up in T12900#228748 for other strings I might have missed.

Screen Shot 2017-07-05 at 9.35.41 AM.png (807×1 px, 86 KB)

Diff Detail

Repository

Branch

phame1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17626
Build 23662: Run Core Tests
Build 23661: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 5 2017, 4:55 PM

Harbormaster completed remote builds in B17626: Diff 43737.Jul 5 2017, 4:56 PM

chad accepted this revision.Jul 5 2017, 6:53 PM

This revision is now accepted and ready to land.Jul 5 2017, 6:53 PM

Closed by commit rP8d11e127ff15: Fix several pieces of UI language describing "draft/archive" rules in Phame (authored by epriestley, committed by epriestley). · Explain WhyJul 6 2017, 3:13 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.Jul 6 2017, 3:15 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

controller/

post/

PhamePostArchiveController.php

5 lines

PhamePostViewController.php

12 lines

storage/

5 lines

Diff 43737

src/applications/phame/controller/post/PhamePostArchiveController.php

Loading...

src/applications/phame/controller/post/PhamePostViewController.php

Loading...

src/applications/phame/storage/PhamePost.php

Loading...