Differential D18162

New icons for Projects
ClosedPublic
Actions

Authored by chad on Jun 27 2017, 10:37 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 7, 9:36 AM

	Unknown Object (File)
	Fri, May 3, 9:25 AM

	Unknown Object (File)
	Tue, Apr 30, 1:40 PM

	Unknown Object (File)
	Thu, Apr 25, 6:54 AM

	Unknown Object (File)
	Thu, Apr 25, 3:04 AM

	Unknown Object (File)
	Thu, Apr 11, 7:34 AM

	Unknown Object (File)
	Mar 30 2024, 5:31 PM

	Unknown Object (File)
	Mar 24 2024, 8:51 PM

View All 48 Files

Subscribers

Details

Reviewers

Commits

rPd6450bf7d255: New icons for Projects

Summary

Updates the builtin images, leaves the old choose... icons for now. I'd like to automate this based on icon when creating a project.

Test Plan

Visit edit picture page, pick a few. Purge cache, see new default image.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Jun 27 2017, 10:37 AM

Herald added a subscriber: Korvin. · View Herald TranscriptJun 27 2017, 10:37 AM

patiently awaits color commentary

epriestley accepted this revision.Jun 27 2017, 12:50 PM

epriestley added inline comments.

resources/builtin/project.png
1	The latch on this bag appears to be closed but one of our core values is OPENNESS.
resources/builtin/projects/v3/bug.png
1	Are these legs attached to the ABDOMEN instead of the THORAX? Ridiculous!
resources/builtin/projects/v3/calendar.png
1	This one is exactly accurate.
resources/builtin/projects/v3/people.png
1	I'm pretty sure this is two elves in tunics and that is great.

This revision is now accepted and ready to land.Jun 27 2017, 12:50 PM

Closed by commit rPd6450bf7d255: New icons for Projects (authored by chad, committed by chad). · Explain WhyJun 27 2017, 1:02 PM

This revision was automatically updated to reflect the committed changes.

Maybe one real piece of feedback is to consider a neutral or more varied palette of skin tones for the elves, they're pretty whitebread.

good idea. tempted to put a klingon on the right rear too.

Revision Contents
Changeset List

Path

Size

resources/

builtin/

projects/

v3/

experimental.png

organization.png

src/

applications/

project/

controller/

PhabricatorProjectEditPictureController.php

36 lines

Diff 43694

resources/builtin/project.png

Loading...

resources/builtin/projects/v3/briefcase.png

Loading...

resources/builtin/projects/v3/bug.png

Loading...

resources/builtin/projects/v3/calendar.png

Loading...

resources/builtin/projects/v3/cloud.png

Loading...

resources/builtin/projects/v3/creditcard.png

Loading...

resources/builtin/projects/v3/database.png

Loading...

resources/builtin/projects/v3/desktop.png

Loading...

resources/builtin/projects/v3/experimental.png

Loading...

resources/builtin/projects/v3/flag.png

Loading...

resources/builtin/projects/v3/folder.png

Loading...

resources/builtin/projects/v3/lock.png

Loading...

resources/builtin/projects/v3/mail.png

Loading...

resources/builtin/projects/v3/mobile.png

Loading...

resources/builtin/projects/v3/organization.png

Loading...

resources/builtin/projects/v3/people.png

Loading...

resources/builtin/projects/v3/servers.png

Loading...

resources/builtin/projects/v3/tag.png

Loading...

resources/builtin/projects/v3/trash.png

Loading...

resources/builtin/projects/v3/truck.png

Loading...

resources/builtin/projects/v3/umbrella.png

Loading...

src/applications/project/controller/PhabricatorProjectEditPictureController.php

Loading...