Page MenuHomePhabricator
Differential D18159

Convert 'class' config options to new validation
ClosedPublic
Actions

Authored by epriestley on Jun 26 2017, 5:15 PM.
Tags
None
Referenced Files
F15453839: D18159.diff
Sat, Mar 29, 2:45 PM
F15452234: D18159.id43706.diff
Sat, Mar 29, 3:18 AM
F15448920: D18159.id43687.diff
Fri, Mar 28, 7:40 AM
F15446228: D18159.id.diff
Thu, Mar 27, 5:51 PM
F15441490: D18159.diff
Wed, Mar 26, 6:30 PM
F15432257: D18159.diff
Mon, Mar 24, 5:05 PM
F15380917: D18159.id43706.diff
Fri, Mar 14, 4:59 AM
Unknown Object (File)
Feb 24 2025, 4:33 AM
View All Files
Subscribers
None

Details

Reviewers
chad
amckinley
Maniphest Tasks
T12845: Convert remaining ancient configuration type classes to modern modular type classes
Commits
rP0afdabff00ae: Convert 'class' config options to new validation
Summary

Ref T12845. These options prompt the user to select from among concrete subclasses of some base class.

Test Plan

Set, deleted and mangled these values from the web UI and CLI.

Diff Detail

Repository
rP Phabricator
Branch
config5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17578
Build 23591: Run Core Tests
Build 23590: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 26 2017, 5:15 PM
Harbormaster completed remote builds in B17578: Diff 43687.Jun 26 2017, 5:16 PM
amckinley accepted this revision.Jun 26 2017, 6:14 PM
This revision is now accepted and ready to land.Jun 26 2017, 6:14 PM
Closed by commit rP0afdabff00ae: Convert 'class' config options to new validation (authored by epriestley, committed by epriestley). · Explain WhyJun 27 2017, 7:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43687

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigEditController.php

Loading...
View Options

src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php

Loading...
View Options

src/applications/config/option/PhabricatorApplicationConfigOptions.php

Loading...
View Options

src/applications/config/type/PhabricatorClassConfigType.php

Loading...
Phabricator · Built by Phacility