Convert "bool" config values to new modular system
ClosedPublic
Actions

Authored by epriestley on Jun 26 2017, 4:57 PM.

Details

Reviewers

chad
amckinley

Maniphest Tasks

T12845: Convert remaining ancient configuration type classes to modern modular type classes

Commits

rP72119e786c79: Convert "bool" config values to new modular system

Summary

Ref T12845. Moves the "bool" values over.

Test Plan

Set, deleted, and mangled bool values from CLI and web UI.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 26 2017, 4:57 PM

Harbormaster completed remote builds in B17575: Diff 43684.Jun 26 2017, 4:58 PM

Remove slightly more dead code.

Harbormaster completed remote builds in B17576: Diff 43685.Jun 26 2017, 4:59 PM

Harbormaster completed remote builds in B17576: Diff 43685.

Even more dead code!

Harbormaster completed remote builds in B17577: Diff 43686.Jun 26 2017, 5:02 PM

amckinley accepted this revision.Jun 26 2017, 5:10 PM

This revision is now accepted and ready to land.Jun 26 2017, 5:10 PM

Closed by commit rP72119e786c79: Convert "bool" config values to new modular system (authored by epriestley, committed by epriestley). · Explain WhyJun 27 2017, 7:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

config/

controller/

PhabricatorConfigEditController.php

25 lines

management/

PhabricatorConfigManagementSetWorkflow.php

15 lines

option/

PhabricatorApplicationConfigOptions.php

9 lines

type/

PhabricatorBoolConfigType.php

62 lines

Diff 43704

View Options

src/__phutil_library_map__.php

View Options

src/applications/config/controller/PhabricatorConfigEditController.php

View Options

src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php

View Options

src/applications/config/option/PhabricatorApplicationConfigOptions.php

View Options

src/applications/config/type/PhabricatorBoolConfigType.php

Convert "bool" config values to new modular systemClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43704

src/__phutil_library_map__.php

src/applications/config/controller/PhabricatorConfigEditController.php

src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php

src/applications/config/option/PhabricatorApplicationConfigOptions.php

src/applications/config/type/PhabricatorBoolConfigType.php

Convert "bool" config values to new modular system
ClosedPublic
Actions

Revision Contents
Changeset List