Page MenuHomePhabricator

Add profile images to Repositories
ClosedPublic

Authored by chad on Jun 12 2017, 3:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 25, 6:10 PM
Unknown Object (File)
Dec 17 2022, 5:26 AM
Unknown Object (File)
Dec 11 2022, 8:30 PM
Unknown Object (File)
Dec 7 2022, 4:57 AM
Unknown Object (File)
Nov 20 2022, 2:21 PM
Unknown Object (File)
Nov 12 2022, 12:25 AM
Unknown Object (File)
Nov 10 2022, 10:14 PM
Unknown Object (File)
Oct 2 2022, 11:56 AM
Subscribers

Details

Summary

Builds out some images to use to identify repositories. Fixes T12825.

Test Plan

Try setting custom, built in, and null images.

image.png (782×978 px, 75 KB)

image.png (552×924 px, 75 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • fix failing harbormaster build

Are there license issues with these? They're from GitHub's icons, right?

This revision is now accepted and ready to land.Jun 12 2017, 2:14 PM

3 of the icons are, https://github.com/primer/octicons/blob/master/LICENSE

Do we need to add a license somewhere for dirivitive?

Maybe just put externals/octicons/ with the README and LICENSE?

This revision was automatically updated to reflect the committed changes.