Page MenuHomePhabricator

Remove obsolete "arc land" flags: --update-with-merge/rebase, --delete-remote
ClosedPublic

Authored by epriestley on Jun 9 2017, 1:58 PM.
Tags
None
Referenced Files
F13138256: D18108.diff
Thu, May 2, 11:42 PM
Unknown Object (File)
Thu, Apr 25, 3:57 AM
Unknown Object (File)
Fri, Apr 19, 6:36 PM
Unknown Object (File)
Thu, Apr 11, 12:24 PM
Unknown Object (File)
Fri, Apr 5, 3:14 PM
Unknown Object (File)
Mar 31 2024, 8:57 AM
Unknown Object (File)
Mar 27 2024, 8:14 PM
Unknown Object (File)
Mar 23 2024, 2:12 PM
Subscribers
None

Details

Summary

Fixes T12815. During the last update to "arc land", some flags were disabled but remained in place in case we needed to retain them.

It now seems reasonably clear that we do not. The "rebase" and "merge" strategies for landing were replaced by a better "headless" strategy which seems to avoid the original issues, so these flags no longer do anything or reasonably could do anything.

--delete-remote is slightly more ambiguous (e.g., see T12650 and maybe others) but the only real use case is "git push = save changes".

Test Plan

Ran arc land --update-with-rebase, was told the flag does not exist.
Grepped for affected flags/symbols.

Diff Detail

Repository
rARC Arcanist
Branch
land1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17459
Build 23406: Run Core Tests
Build 23405: arc lint + arc unit

Event Timeline

epriestley retitled this revision from Remove obsolete "arc land" flags to Remove obsolete "arc land" flags: --update-with-merge/rebase, --delete-remote.
This revision is now accepted and ready to land.Jun 9 2017, 2:13 PM
This revision was automatically updated to reflect the committed changes.