Differential D18056

Allow buttons to just be icons
ClosedPublic
Actions

Authored by chad on May 31 2017, 8:00 PM.

Details

Reviewers

epriestley

Commits

rPc001781264b4: Allow buttons to just be icons

Summary

Let's buttons just be an icon, no pressure to also have text.

Test Plan

UIExamples, Search, Home, Policy Controls... Probably 99% of them.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.May 31 2017, 8:00 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 31 2017, 8:00 PM

Harbormaster completed remote builds in B17342: Diff 43429.May 31 2017, 8:00 PM

Harbormaster completed remote builds in B17342: Diff 43429.

button-bar

Harbormaster completed remote builds in B17343: Diff 43430.May 31 2017, 8:13 PM

epriestley accepted this revision.Jun 1 2017, 12:29 PM

This revision is now accepted and ready to land.Jun 1 2017, 12:29 PM

Closed by commit rPc001781264b4: Allow buttons to just be icons (authored by chad, committed by chad). · Explain WhyJun 1 2017, 1:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

28 lines

src/

applications/

uiexample/

examples/

PHUIButtonExample.php

12 lines

view/

form/

control/

AphrontFormPolicyControl.php

2 lines

phui/

PHUIButtonView.php

24 lines

webroot/

rsrc/

css/

application/

base/

main-menu-view.css

1 line

phui/

phui-button.css

14 lines

js/

phuix/

PHUIXButtonView.js

1 line

Diff 43432

View Options

resources/celerity/map.php

View Options

src/applications/uiexample/examples/PHUIButtonExample.php

View Options

src/view/form/control/AphrontFormPolicyControl.php

View Options

src/view/phui/PHUIButtonView.php

View Options

webroot/rsrc/css/application/base/main-menu-view.css

View Options

webroot/rsrc/css/phui/phui-button.css

View Options

webroot/rsrc/js/phuix/PHUIXButtonView.js

Allow buttons to just be iconsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43432

resources/celerity/map.php

src/applications/uiexample/examples/PHUIButtonExample.php

src/view/form/control/AphrontFormPolicyControl.php

src/view/phui/PHUIButtonView.php

webroot/rsrc/css/application/base/main-menu-view.css

webroot/rsrc/css/phui/phui-button.css

webroot/rsrc/js/phuix/PHUIXButtonView.js

Allow buttons to just be icons
ClosedPublic
Actions

Revision Contents
Changeset List