Page MenuHomePhabricator
Differential D18027

Modernize FeedQuery a little bit
ClosedPublic
Actions

Authored by epriestley on May 26 2017, 4:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 3:50 AM
Unknown Object (File)
Sun, Apr 7, 3:50 AM
Unknown Object (File)
Sun, Apr 7, 3:36 AM
Unknown Object (File)
Sun, Apr 7, 2:14 AM
Unknown Object (File)
Sun, Apr 7, 1:51 AM
Unknown Object (File)
Sun, Apr 7, 1:21 AM
Unknown Object (File)
Sat, Apr 6, 10:24 PM
Unknown Object (File)
Tue, Apr 2, 3:37 PM
View All 74 Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12762: Feed queries should support date range constraints
Commits
rP2d7922908343: Modernize FeedQuery a little bit
Summary

Ref T12762. Updates some conventions and methods. This has no (meaningful) behavioral changes.

Test Plan
  • Grepped for setFilterPHIDs().
  • Viewed main feed, user feed, project feed.
  • Called feed.query.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 26 2017, 4:45 PM
chad accepted this revision.May 26 2017, 4:45 PM
This revision is now accepted and ready to land.May 26 2017, 4:45 PM
Harbormaster completed remote builds in B17270: Diff 43359.May 26 2017, 4:46 PM
Closed by commit rP2d7922908343: Modernize FeedQuery a little bit (authored by epriestley, committed by epriestley). · Explain WhyMay 26 2017, 6:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
feed/
conduit/
10 lines
query/
60 lines
2 lines
people/
controller/
2 lines
project/
controller/
2 lines

Diff 43368

View Options

src/applications/feed/conduit/FeedQueryConduitAPIMethod.php

Loading...
View Options

src/applications/feed/query/PhabricatorFeedQuery.php

Loading...
View Options

src/applications/feed/query/PhabricatorFeedSearchEngine.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
Phabricator · Built by Phacility