Page MenuHomePhabricator
Differential D18021

Move setLaunchButton to setSideColumn for ObjectItem
ClosedPublic
Actions

Authored by chad on May 25 2017, 10:27 PM.
Tags
None
Referenced Files
F17755530: D18021.diff
Tue, Jul 22, 12:33 PM
Unknown Object (File)
Jun 21 2025, 5:13 PM
Unknown Object (File)
Jun 18 2025, 1:44 PM
Unknown Object (File)
Jun 17 2025, 7:59 AM
Unknown Object (File)
May 9 2025, 3:25 PM
Unknown Object (File)
May 6 2025, 12:27 PM
Unknown Object (File)
Apr 30 2025, 1:10 PM
Unknown Object (File)
Apr 29 2025, 7:42 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP9bbea869b3dd: Move setLaunchButton to setSideColumn for ObjectItem
Summary

Makes this a bit more flexible and allow UI to take over col-2 completely. Also cleaned up application search a little with tags

Test Plan

Review various pages, grep for callsites.

Diff Detail

Repository
rP Phabricator
Branch
set-launch-button (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17258
Build 23113: Run Core Tests
Build 23112: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
guides/
view/
4 lines
meta/
query/
33 lines
phame/
query/
5 lines
view/
phui/
14 lines
webroot/
rsrc/
css/
phui/
object-item/
4 lines

Diff 43346

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/guides/view/PhabricatorGuideListView.php

Loading...
View Options

src/applications/meta/query/PhabricatorAppSearchEngine.php

Loading...
View Options

src/applications/phame/query/PhameBlogSearchEngine.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
View Options

webroot/rsrc/css/phui/object-item/phui-oi-list-view.css

Loading...
Phabricator · Built by Phacility