Page MenuHomePhabricator
Differential D18021

Move setLaunchButton to setSideColumn for ObjectItem
ClosedPublic
Actions

Authored by chad on May 25 2017, 10:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 12:12 PM
Unknown Object (File)
Nov 19 2024, 10:15 AM
Unknown Object (File)
Oct 16 2024, 10:41 PM
Unknown Object (File)
Oct 14 2024, 3:13 AM
Unknown Object (File)
Sep 4 2024, 2:26 PM
Unknown Object (File)
Sep 4 2024, 5:54 AM
Unknown Object (File)
Aug 28 2024, 1:11 PM
Unknown Object (File)
Aug 23 2024, 3:10 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP9bbea869b3dd: Move setLaunchButton to setSideColumn for ObjectItem
Summary

Makes this a bit more flexible and allow UI to take over col-2 completely. Also cleaned up application search a little with tags

Test Plan

Review various pages, grep for callsites.

Diff Detail

Repository
rP Phabricator
Branch
set-launch-button (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17258
Build 23113: Run Core Tests
Build 23112: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
guides/
view/
4 lines
meta/
query/
33 lines
phame/
query/
5 lines
view/
phui/
14 lines
webroot/
rsrc/
css/
phui/
object-item/
4 lines

Diff 43346

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/guides/view/PhabricatorGuideListView.php

Loading...
View Options

src/applications/meta/query/PhabricatorAppSearchEngine.php

Loading...
View Options

src/applications/phame/query/PhameBlogSearchEngine.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
View Options

webroot/rsrc/css/phui/object-item/phui-oi-list-view.css

Loading...
Phabricator · Built by Phacility