Page MenuHomePhabricator
Differential D18011

Make throwing things into the trash actually work in Nuance
ClosedPublic
Actions

Authored by epriestley on May 24 2017, 5:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 3:20 AM
Unknown Object (File)
Mon, Apr 22, 9:14 AM
Unknown Object (File)
Mon, Apr 22, 9:13 AM
Unknown Object (File)
Mon, Apr 22, 9:13 AM
Unknown Object (File)
Mon, Apr 22, 9:00 AM
Unknown Object (File)
Fri, Apr 19, 6:32 PM
Unknown Object (File)
Thu, Apr 18, 12:23 PM
Unknown Object (File)
Thu, Apr 11, 10:41 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12738: Nuance: As a Helpdesk, for Phabricator/Phacility support
Commits
rP8374ec46fdab: Make throwing things into the trash actually work in Nuance
Summary

Ref T12738. Implements some modular behavior for Nuance commands.

Test Plan

Screen Shot 2017-05-24 at 10.51.02 AM.png (347×1 px, 52 KB)

Diff Detail

Repository
rP Phabricator
Branch
nuance8
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/nuance/command/NuanceCommandImplementation.php:67XHP16TODO Comment
Advicesrc/applications/nuance/item/NuanceGitHubEventItemType.php:332XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 17229
Build 23068: Run Core Tests
Build 23067: arc lint + arc unit

Event Timeline

epriestley created this revision.May 24 2017, 5:53 PM
Harbormaster completed remote builds in B17229: Diff 43317.May 24 2017, 5:54 PM
chad accepted this revision.May 24 2017, 5:56 PM
This revision is now accepted and ready to land.May 24 2017, 5:56 PM
Closed by commit rP8374ec46fdab: Make throwing things into the trash actually work in Nuance (authored by epriestley, committed by epriestley). · Explain WhyMay 24 2017, 6:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43317

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/nuance/command/NuanceCommandImplementation.php

Loading...
View Options

src/applications/nuance/command/NuanceTrashCommand.php

Loading...
View Options

src/applications/nuance/item/NuanceGitHubEventItemType.php

Loading...
View Options

src/applications/nuance/item/NuanceItemType.php

Loading...
View Options

src/applications/nuance/storage/NuanceItem.php

Loading...
View Options

src/applications/nuance/worker/NuanceItemUpdateWorker.php

Loading...
View Options

src/applications/nuance/xaction/NuanceItemCommandTransaction.php

Loading...
View Options

src/applications/nuance/xaction/NuanceItemStatusTransaction.php

Loading...
Phabricator · Built by Phacility