Page MenuHomePhabricator

Issue commands to Nuance items, at least roughly
ClosedPublic

Authored by epriestley on May 24 2017, 4:35 PM.
Tags
None
Referenced Files
F13060879: D18010.diff
Fri, Apr 19, 6:32 PM
Unknown Object (File)
Wed, Apr 17, 2:58 PM
Unknown Object (File)
Sat, Apr 13, 5:32 PM
Unknown Object (File)
Sat, Apr 13, 4:48 PM
Unknown Object (File)
Sat, Apr 13, 1:48 PM
Unknown Object (File)
Sat, Apr 13, 1:06 PM
Unknown Object (File)
Sat, Apr 13, 12:51 PM
Unknown Object (File)
Fri, Apr 12, 10:36 PM
Subscribers
None

Details

Summary

Ref T12738. This makes clicking "Throw In Trash" technically do something, sort of.

In Nuance, the default mode of operation for actions is asynchronous -- so you don't have to wait for a response from Twitter or GitHub after you mash the "send default reply tweet" / "close this pull request with a nice response" button and can move directly to the next item instead.

In the future, some operations will attempt to apply synchronously (e.g., local actions like "ignore this item forever"). This fakes our way through that for now.

There's also no connection to the action actually doing anything yet, but I'll probably rig that up next.

Test Plan

Screen Shot 2017-05-24 at 9.29.12 AM.png (949×1 px, 149 KB)

Diff Detail

Repository
rP Phabricator
Branch
nuance7
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/nuance/controller/NuanceItemActionController.php:67XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 17226
Build 23063: Run Core Tests
Build 23062: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 24 2017, 4:38 PM
This revision was automatically updated to reflect the committed changes.