Page MenuHomePhabricator
Differential D18007

Fix a handful of Nuance fatals
ClosedPublic
Actions

Authored by epriestley on May 24 2017, 1:44 PM.
Tags
None
Referenced Files
F19051198: D18007.diff
Thu, Nov 27, 11:32 PM
F19051188: D18007.diff
Thu, Nov 27, 11:29 PM
F18937532: D18007.diff
Mon, Nov 10, 11:42 PM
F18840531: D18007.diff
Oct 28 2025, 1:46 AM
F18828262: D18007.diff
Oct 24 2025, 3:26 PM
F18782957: D18007.id43310.diff
Oct 13 2025, 3:08 AM
F18733611: D18007.id.diff
Sep 30 2025, 10:38 PM
F18671762: D18007.id43318.diff
Sep 25 2025, 5:09 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12738: Nuance: As a Helpdesk, for Phabricator/Phacility support
Commits
rP272a5d668f9e: Fix a handful of Nuance fatals
Summary

Ref T12738. Some of the Nuance "form" workflows currently fatal after work on the GitHub stuff. Try to make everything stop fataling, at least.

Test Plan

Using "Complaints Form" no longer fatals, and now lodges a complaint instead.

Diff Detail

Repository
rP Phabricator
Branch
nuance4
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/nuance/storage/NuanceItem.php:31XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 17222
Build 23056: Run Core Tests
Build 23055: arc lint + arc unit

Event Timeline

epriestley created this revision.May 24 2017, 1:44 PM
Harbormaster completed remote builds in B17222: Diff 43310.May 24 2017, 1:45 PM
chad accepted this revision.May 24 2017, 2:02 PM
This revision is now accepted and ready to land.May 24 2017, 2:02 PM
Closed by commit rP272a5d668f9e: Fix a handful of Nuance fatals (authored by epriestley, committed by epriestley). · Explain WhyMay 24 2017, 6:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43310

View Options

resources/sql/autopatches/20170522.nuance.01.itemkey.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/nuance/cursor/NuanceGitHubIssuesImportCursor.php

Loading...
View Options

src/applications/nuance/cursor/NuanceGitHubRepositoryImportCursor.php

Loading...
View Options

src/applications/nuance/item/NuanceFormItemType.php

Loading...
View Options

src/applications/nuance/phid/NuanceItemPHIDType.php

Loading...
View Options

src/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php

Loading...
View Options

src/applications/nuance/source/NuanceSourceDefinition.php

Loading...
View Options

src/applications/nuance/storage/NuanceItem.php

Loading...
View Options

src/applications/nuance/xaction/NuanceItemPropertyTransaction.php

Loading...
Phabricator · Built by Phacility