Page MenuHomePhabricator
Differential D17985

Add slugs to project manage page
ClosedPublic
Actions

Authored by chad on May 20 2017, 5:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 4, 8:23 AM
Unknown Object (File)
Fri, Jan 3, 11:15 PM
Unknown Object (File)
Mon, Dec 30, 6:50 AM
Unknown Object (File)
Mon, Dec 30, 6:50 AM
Unknown Object (File)
Sun, Dec 29, 3:12 AM
Unknown Object (File)
Tue, Dec 17, 10:32 AM
Unknown Object (File)
Thu, Dec 12, 6:17 AM
Unknown Object (File)
Dec 9 2024, 6:54 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
amckinley
Commits
rPc4392ba06757: Add slugs to project manage page
Summary

Minor, just shows the slugs on the manage project page, also normalized language to "details"

Test Plan

review a project with slugs, description.

Diff Detail

Repository
rP Phabricator
Branch
slugs (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17227
Build 23065: Run Core Tests
Build 23064: arc lint + arc unit

Event Timeline

chad created this revision.May 20 2017, 5:52 PM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 20 2017, 5:52 PM
Harbormaster completed remote builds in B17174: Diff 43255.May 20 2017, 5:53 PM
chad added a reviewer: amckinley.May 22 2017, 8:02 PM
epriestley edited edge metadata.May 22 2017, 10:17 PM

This one slipped by me, but we can pretend I got hit by a bus and @amckinley needs to ensure business continuity.

chad removed a reviewer: epriestley.May 22 2017, 10:25 PM
chad added a comment.May 23 2017, 6:08 PM

halps

chad added a comment.May 23 2017, 7:50 PM

This one is slipping by everyone.

epriestley added a subscriber: epriestley.May 23 2017, 8:29 PM

Slugs are slippery!

slimySlug1a.png (331×550 px, 215 KB)

chad added a comment.May 23 2017, 8:29 PM

I have faith.

chad added a comment.May 23 2017, 8:30 PM

Also, sorry to hear about your bus accident.

epriestley added a comment.May 23 2017, 8:43 PM

It has been tough on all of us.

chad added a comment.May 24 2017, 4:37 PM

tumbleweed3.jpg (720×960 px, 251 KB)

amckinley edited edge metadata.May 24 2017, 4:43 PM

ohai

amckinley accepted this revision.May 24 2017, 4:44 PM

Looks good unless you want to move this function.

src/applications/project/controller/PhabricatorProjectManageController.php
156

Should this live in the Project class?

This revision is now accepted and ready to land.May 24 2017, 4:44 PM
chad updated this revision to Diff 43315.May 24 2017, 5:19 PM
  • move it up a level for future use
Harbormaster completed remote builds in B17227: Diff 43315.May 24 2017, 5:20 PM
Closed by commit rPc4392ba06757: Add slugs to project manage page (authored by chad, committed by chad). · Explain WhyMay 24 2017, 5:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43315

View Options

src/applications/project/controller/PhabricatorProjectController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectManageController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
Phabricator · Built by Phacility