Page MenuHomePhabricator
Differential D17982

Show the curent selected inline in the objective list
ClosedPublic
Actions

Authored by epriestley on May 20 2017, 1:00 PM.
Tags
None
Referenced Files
F13046321: D17982.diff
Thu, Apr 18, 8:46 AM
Unknown Object (File)
Mon, Apr 15, 7:57 PM
Unknown Object (File)
Sat, Apr 13, 9:39 PM
Unknown Object (File)
Sat, Apr 13, 9:27 PM
Unknown Object (File)
Sat, Apr 13, 8:25 PM
Unknown Object (File)
Sat, Apr 13, 4:55 PM
Unknown Object (File)
Sat, Apr 13, 4:06 PM
Unknown Object (File)
Sat, Apr 13, 3:26 PM
View All 91 Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12733: (2017 Week 20) Inline Comments Errata / Feedback
Commits
rP4d2c7e4d3d5d: (stable) Show the curent selected inline in the objective list
rP7d44e7cb4d2f: Show the curent selected inline in the objective list
Summary

Ref T12733. When an inline is selected, make it stand out so you can see where you are in the document more clearly.

Test Plan

Screen Shot 2017-05-20 at 5.59.33 AM.png (396×1 px, 41 KB)

Diff Detail

Repository
rP Phabricator
Branch
map9
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17147
Build 22948: Run Core Tests
Build 22947: arc lint + arc unit

Event Timeline

epriestley created this revision.May 20 2017, 1:00 PM
Harbormaster completed remote builds in B17147: Diff 43239.May 20 2017, 1:01 PM
chad accepted this revision.May 20 2017, 2:34 PM
This revision is now accepted and ready to land.May 20 2017, 2:34 PM
Closed by commit rP7d44e7cb4d2f: Show the curent selected inline in the objective list (authored by epriestley, committed by epriestley). · Explain WhyMay 20 2017, 3:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
24 lines
webroot/
rsrc/
js/
application/
diff/
16 lines
7 lines

Diff 43239

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility