Page MenuHomePhabricator
Differential D17977

Make Differential objective markers show a brighter "editing" state
ClosedPublic
Actions

Authored by epriestley on May 20 2017, 12:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 31, 10:07 PM
Unknown Object (File)
Tue, Dec 31, 9:18 PM
Unknown Object (File)
Fri, Dec 13, 5:29 AM
Unknown Object (File)
Dec 7 2024, 3:17 AM
Unknown Object (File)
Nov 27 2024, 3:49 AM
Unknown Object (File)
Nov 23 2024, 2:49 PM
Unknown Object (File)
Nov 21 2024, 3:50 PM
Unknown Object (File)
Nov 19 2024, 3:50 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12733: (2017 Week 20) Inline Comments Errata / Feedback
Commits
rP429a0ce4e699: (stable) Make Differential objective markers show a brighter "editing" state
rPaf07600aaac7: Make Differential objective markers show a brighter "editing" state
Summary

Ref T12733.

  • While editing a comment, show a pink star () with a tooltip.
  • Slight UI tweaks, including draft comments getting an indigo pencil ().
Test Plan

Screen Shot 2017-05-20 at 5.01.06 AM.png (254×464 px, 14 KB)

Diff Detail

Repository
rP Phabricator
Branch
map4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17142
Build 22938: Run Core Tests
Build 22937: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
40 lines
src/
applications/
differential/
view/
2 lines
webroot/
rsrc/
css/
application/
differential/
5 lines
js/
application/
diff/
29 lines
core/
4 lines

Diff 43234

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetListView.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
View Options

webroot/rsrc/js/core/ToolTip.js

Loading...
Phabricator · Built by Phacility