Differential D17958

Migrate Project color to modular transactions
ClosedPublic
Actions

Authored by amckinley on May 18 2017, 11:40 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rP7e46d7ab6a6b: Migrate Project color to modular transactions

Test Plan

Unit tests + changing project colors.

Diff Detail

Repository

rP Phabricator

Branch

project-color (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17102
Build 22877: Run Core Tests
Build 22876: arc lint + arc unit

Event Timeline

amckinley created this revision.May 18 2017, 11:40 PM

Herald added a subscriber: epriestley. · View Herald TranscriptMay 18 2017, 11:40 PM

Harbormaster completed remote builds in B17102: Diff 43191.May 18 2017, 11:40 PM

🐕

This revision is now accepted and ready to land.May 18 2017, 11:40 PM

Harbormaster completed remote builds in B17102: Diff 43191.May 18 2017, 11:41 PM

Closed by commit rP7e46d7ab6a6b: Migrate Project color to modular transactions (authored by amckinley, committed by amckinley). · Explain WhyMay 18 2017, 11:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

__phutil_library_map__.php

2 lines

applications/

project/

conduit/

ProjectCreateConduitAPIMethod.php

6 lines

15%

editor/

PhabricatorProjectTransactionEditor.php

10 lines

67%

engine/

PhabricatorProjectEditEngine.php

5 lines

storage/

PhabricatorProjectTransaction.php

17 lines

xaction/

PhabricatorProjectColorTransaction.php

33 lines

12%

Diff 43191

View Options

src/__phutil_library_map__.php

View Options

src/applications/project/conduit/ProjectCreateConduitAPIMethod.php

View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

View Options

src/applications/project/engine/PhabricatorProjectEditEngine.php

View Options

src/applications/project/storage/PhabricatorProjectTransaction.php

View Options

src/applications/project/xaction/PhabricatorProjectColorTransaction.php

Migrate Project color to modular transactionsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43191

src/__phutil_library_map__.php

src/applications/project/conduit/ProjectCreateConduitAPIMethod.php

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

src/applications/project/engine/PhabricatorProjectEditEngine.php

src/applications/project/storage/PhabricatorProjectTransaction.php

src/applications/project/xaction/PhabricatorProjectColorTransaction.php

Migrate Project color to modular transactions
ClosedPublic
Actions

Revision Contents
Changeset List