Differential D17956

Migrate Project icons to modular transactions
ClosedPublic
Actions

Authored by amckinley on May 18 2017, 11:23 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rP1bff5309e667: Migrate Project icons to modular transactions

Test Plan

Unit tests pass. Changed some icons, observed expected timeline entries.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

amckinley created this revision.May 18 2017, 11:23 PM

Herald added a subscriber: epriestley. · View Herald TranscriptMay 18 2017, 11:23 PM

Harbormaster completed remote builds in B17099: Diff 43188.May 18 2017, 11:24 PM

epriestley accepted this revision.May 18 2017, 11:25 PM

This revision is now accepted and ready to land.May 18 2017, 11:25 PM

Closed by commit rP1bff5309e667: Migrate Project icons to modular transactions (authored by amckinley, committed by amckinley). · Explain WhyMay 18 2017, 11:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

project/

conduit/

ProjectCreateConduitAPIMethod.php

2 lines

editor/

PhabricatorProjectTransactionEditor.php

10 lines

engine/

PhabricatorProjectEditEngine.php

4 lines

storage/

PhabricatorProjectTransaction.php

24 lines

xaction/

PhabricatorProjectIconTransaction.php

42 lines

Diff 43189

View Options

src/__phutil_library_map__.php

View Options

src/applications/project/conduit/ProjectCreateConduitAPIMethod.php

View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

View Options

src/applications/project/engine/PhabricatorProjectEditEngine.php

View Options

src/applications/project/storage/PhabricatorProjectTransaction.php

View Options

src/applications/project/xaction/PhabricatorProjectIconTransaction.php

Migrate Project icons to modular transactionsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43189

src/__phutil_library_map__.php

src/applications/project/conduit/ProjectCreateConduitAPIMethod.php

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

src/applications/project/engine/PhabricatorProjectEditEngine.php

src/applications/project/storage/PhabricatorProjectTransaction.php

src/applications/project/xaction/PhabricatorProjectIconTransaction.php

Migrate Project icons to modular transactions
ClosedPublic
Actions

Revision Contents
Changeset List