Page MenuHomePhabricator
Differential D17956

Migrate Project icons to modular transactions
ClosedPublic
Actions

Authored by amckinley on May 18 2017, 11:23 PM.
Tags
None
Referenced Files
F16391857: D17956.diff
Mon, Jun 16, 12:43 AM
Unknown Object (File)
May 10 2025, 10:09 AM
Unknown Object (File)
May 7 2025, 6:36 PM
Unknown Object (File)
May 1 2025, 6:04 PM
Unknown Object (File)
Apr 30 2025, 6:24 AM
Unknown Object (File)
Apr 20 2025, 11:07 PM
Unknown Object (File)
Apr 12 2025, 12:50 PM
Unknown Object (File)
Mar 23 2025, 1:27 PM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rP1bff5309e667: Migrate Project icons to modular transactions
Test Plan

Unit tests pass. Changed some icons, observed expected timeline entries.

Diff Detail

Repository
rP Phabricator
Branch
project-icon (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17099
Build 22872: Run Core Tests
Build 22871: arc lint + arc unit

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
2 lines--
applications/
project/
conduit/
2 lines16%
Loading...
editor/
10 lines67%
Loading...
engine/
4 lines1%
Loading...
storage/
24 lines2%
Loading...
xaction/
42 lines10%
Loading...

Diff 43188

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/project/conduit/ProjectCreateConduitAPIMethod.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...
View Options

src/applications/project/engine/PhabricatorProjectEditEngine.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectTransaction.php

Loading...
View Options

src/applications/project/xaction/PhabricatorProjectIconTransaction.php

Loading...
Phabricator · Built by Phacility