Allow setting of button colors in headers
ClosedPublic
Actions

Authored by chad on May 17 2017, 3:15 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 25, 1:04 AM

	Unknown Object (File)
	Sun, Apr 14, 6:20 AM

	Unknown Object (File)
	Thu, Apr 11, 8:45 AM

	Unknown Object (File)
	Tue, Apr 2, 10:04 AM

	Unknown Object (File)
	Feb 9 2024, 6:43 PM

	Unknown Object (File)
	Jan 23 2024, 9:37 AM

	Unknown Object (File)
	Jan 14 2024, 3:29 AM

	Unknown Object (File)
	Dec 20 2023, 5:06 PM

View All 76 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP6ecd6980a142: Allow setting of button colors in headers

Summary

We currently override button color for headers, since the default is blue, but if a developer sets a specific color, we should respect that.

Test Plan

Set a button in the header to green and see green. See grey everywhere else.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.May 17 2017, 3:15 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 17 2017, 3:15 AM

Harbormaster completed remote builds in B17038: Diff 43110.May 17 2017, 3:16 AM

epriestley accepted this revision.May 17 2017, 11:41 AM

This revision is now accepted and ready to land.May 17 2017, 11:41 AM

Closed by commit rP6ecd6980a142: Allow setting of button colors in headers (authored by chad, committed by chad). · Explain WhyMay 17 2017, 1:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUIButtonView.php

4 lines

PHUIHeaderView.php

4 lines

Diff 43117

View Options

src/view/phui/PHUIButtonView.php