Page MenuHomePhabricator
Differential D17879

Move Board Manage actions up a level
ClosedPublic
Actions

Authored by chad on May 14 2017, 9:13 PM.
Tags
None
Referenced Files
F15396481: D17879.id43006.diff
Sun, Mar 16, 2:39 PM
Unknown Object (File)
Feb 10 2025, 4:34 AM
Unknown Object (File)
Feb 7 2025, 4:53 AM
Unknown Object (File)
Feb 6 2025, 11:42 PM
Unknown Object (File)
Jan 30 2025, 1:17 AM
Unknown Object (File)
Jan 21 2025, 3:58 PM
Unknown Object (File)
Jan 21 2025, 10:37 AM
Unknown Object (File)
Jan 13 2025, 6:09 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP89e567ffd945: Move Board Manage actions up a level
rPbc6d25ffc059: Move Board Manage actions up a level
Summary

Moves "reorder columns" and "change background" up a level, redesigns "manage" page to be a little cleaner.

Test Plan

Change colors, reorder columns, manage page, disable board, re-enable board.

Diff Detail

Repository
rP Phabricator
Branch
project-manage-removal (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16928
Build 22621: Run Core Tests
Build 22620: arc lint + arc unit

Event Timeline

chad created this revision.May 14 2017, 9:13 PM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 14 2017, 9:13 PM
Harbormaster completed remote builds in B16928: Diff 43005.May 14 2017, 9:14 PM
epriestley accepted this revision.May 14 2017, 9:16 PM
This revision is now accepted and ready to land.May 14 2017, 9:16 PM
Closed by commit rPbc6d25ffc059: Move Board Manage actions up a level (authored by chad, committed by epriestley). · Explain WhyMay 14 2017, 10:09 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.May 14 2017, 10:22 PM

Oops -- my master was dirty, and bin/host release doesn't currently check for it.

chad added a comment.May 14 2017, 11:08 PM

thanks, was landing and driving home.

chad added a comment.May 14 2017, 11:09 PM

the nice thing about Phab is pretty easy to develop on plane, bandwidth is light

chad added a comment.May 15 2017, 12:40 AM

um, how do we land this on master?

epriestley added a comment.May 15 2017, 12:47 AM

oh haha

epriestley mentioned this in D20634: Move workboard "Bulk Edit Tasks" workflow to a separate controller.Jul 2 2019, 1:25 PM

Revision Contents
Changeset List

Diff 43005

View Options

src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardManageController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardReorderController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
Phabricator · Built by Phacility