Page MenuHomePhabricator

Always show user data from test results
Needs ReviewPublic

Authored by joshuaspence on May 8 2017, 2:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 10:56 AM
Unknown Object (File)
Thu, Apr 4, 7:28 AM
Unknown Object (File)
Sat, Mar 23, 8:37 AM
Unknown Object (File)
Feb 17 2024, 11:28 AM
Unknown Object (File)
Dec 26 2023, 9:43 PM
Unknown Object (File)
Dec 22 2023, 11:43 AM
Unknown Object (File)
Dec 14 2023, 5:37 PM
Unknown Object (File)
Oct 23 2023, 8:44 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

We have a bunch of tests which are passing but producing deprecation warnings. We have a custom test result parsing which does the following:

case 'warning':
  // PHPUnit sets the status to "warning" if the test uses deprecated
  // functionality, but otherwise passes. See
  // https://github.com/sebastianbergmann/phpunit/issues/2194.
  $result->setResult(ArcanistUnitTestResult::RESULT_PASS);
  $result->setUserData(rtrim($message));
  break;

The message, however, is currently not emitted by the console renderer.

Test Plan

Ran arc unit and saw deprecation messages.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16842
Build 22478: Run Core Tests
Build 22477: arc lint + arc unit